tahoe-lafs/trac-2024-07-25
2
0
Issues 1.1k Wiki Activity

.diff for real diffs looks good, aren't downloadable 

[Imported from Trac: page Patches, version 11]
warner 2009-06-21 19:22:28 +00:00
parent d601da2509
commit ad24c74099
1 changed files with 11 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

11
Patches.md

@ -14,3 +14,14 @@ developers view it without first requiring them to download it first. (Trac's co
*.patch and *.diff to some application/blahblah MIME type, which it refuses to display as HTML)
If you don't have darcs or don't want to use it, just attach a normal old diff.
## discussion
If you have an actual diff (as opposed to a darcs patch created with 'darcs send'), then .diff is
good, because Trac knows how to render them. At least it does on the attachements I looked at
on #684 . I haven't checked to see what a darcs patch file attached with a .diff filename looks like,
I think it could get pretty ugly.
On the other hand, downloading the diff with "Download Original Format" gets a content-type which firefox
insists upon saving instead of displaying. I think I'm ok with that.. what I care about is being able to
review the change easily, and Trac's diff markup is pretty good.
-warner