From ad24c740999ce730ce8d1a04050750b998da5571 Mon Sep 17 00:00:00 2001
From: warner <>
Date: Sun, 21 Jun 2009 19:22:28 +0000
Subject: [PATCH] .diff for real diffs looks good, aren't downloadable

[Imported from Trac: page Patches, version 11]
---
 Patches.md | 11 +++++++++++
 1 file changed, 11 insertions(+)

diff --git a/Patches.md b/Patches.md
index e1cac1b..2e4688d 100644
--- a/Patches.md
+++ b/Patches.md
@@ -14,3 +14,14 @@ developers view it without first requiring them to download it first. (Trac's co
 *.patch and *.diff to some application/blahblah MIME type, which it refuses to display as HTML)
 
 If you don't have darcs or don't want to use it, just attach a normal old diff.
+
+## discussion
+
+If you have an actual diff (as opposed to a darcs patch created with 'darcs send'), then .diff is
+good, because Trac knows how to render them. At least it does on the attachements I looked at
+on #684 . I haven't checked to see what a darcs patch file attached with a .diff filename looks like,
+I think it could get pretty ugly.
+On the other hand, downloading the diff with "Download Original Format" gets a content-type which firefox
+insists upon saving instead of displaying. I think I'm ok with that.. what I care about is being able to
+review the change easily, and Trac's diff markup is pretty good.
+-warner