tahoe-lafs/trac-2024-07-25
2
0
Issues 1.1k Wiki Activity

English edit 

[Imported from Trac: page PatchReviewProcess, version 27]
zooko 2013-09-20 20:04:29 +00:00
parent a89e134f40
commit 72598d5ad6
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
PatchReviewProcess.md

@ -42,7 +42,7 @@ A few simple suggestions:
# Experiment: Suspicious Patch Review
Maybe it would be fun to imagine, while you're reviewing a patch, that the author has been compelled to slip a Trojan into the patch by evil adversaries, and it is your job to notice it! That's why you are motivated to request that the author rewrite or explain any confusing parts, because any parts of the patch that confuse the code-reviewer are parts where a Trojan could slip through. Of course, well-written Trojans are indistinguishable from normal old innocent bugs, so if you find a bug this way, give the author the benefit of the doubt and assume that it was an honest mistake.
Maybe it would be fun to imagine, while you're reviewing a patch, that the author has been compelled by evil adversaries to slip a Trojan into the patch, and it is your job to notice it! That's why you are motivated to request that the author rewrite or explain any confusing parts, because any parts of the patch that confuse the code-reviewer are parts where a Trojan could slip through. Of course, well-written Trojans are indistinguishable from normal old innocent bugs, so if you find a bug this way, give the author the benefit of the doubt and assume that it was an honest mistake.
## Using trac and github