From 72598d5ad686aec0f4ae479fcbe5e326a7f2edb7 Mon Sep 17 00:00:00 2001 From: zooko <> Date: Fri, 20 Sep 2013 20:04:29 +0000 Subject: [PATCH] English edit [Imported from Trac: page PatchReviewProcess, version 27] --- PatchReviewProcess.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/PatchReviewProcess.md b/PatchReviewProcess.md index dd23bd4..d39722d 100644 --- a/PatchReviewProcess.md +++ b/PatchReviewProcess.md @@ -42,7 +42,7 @@ A few simple suggestions: # Experiment: Suspicious Patch Review -Maybe it would be fun to imagine, while you're reviewing a patch, that the author has been compelled to slip a Trojan into the patch by evil adversaries, and it is your job to notice it! That's why you are motivated to request that the author rewrite or explain any confusing parts, because any parts of the patch that confuse the code-reviewer are parts where a Trojan could slip through. Of course, well-written Trojans are indistinguishable from normal old innocent bugs, so if you find a bug this way, give the author the benefit of the doubt and assume that it was an honest mistake. +Maybe it would be fun to imagine, while you're reviewing a patch, that the author has been compelled by evil adversaries to slip a Trojan into the patch, and it is your job to notice it! That's why you are motivated to request that the author rewrite or explain any confusing parts, because any parts of the patch that confuse the code-reviewer are parts where a Trojan could slip through. Of course, well-written Trojans are indistinguishable from normal old innocent bugs, so if you find a bug this way, give the author the benefit of the doubt and assume that it was an honest mistake. ## Using trac and github