tahoe-lafs/trac-2024-07-25
2
0
Issues 1.1k Wiki Activity

tweak how-to-review 

[Imported from Trac: page PatchReviewProcess, version 14]
zooko 2011-04-03 00:36:14 +00:00
parent aa2ec76f23
commit 60aa72e55b
1 changed files with 10 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

15
PatchReviewProcess.md

@ -2,10 +2,11 @@
# Why review patches # Why review patches
We want more patches to be contributed to Tahoe-LAFS. Getting We want more patches to be contributed to Tahoe-LAFS. Patches
feedback on patches encourages contributors. Patches languishing in languishing in the "waiting to be reviewed" state discourages
the "waiting to be reviewed" state discourages them. (By the way, contributors. Getting feedback on patches encourages them.
something else that encourages them is users saying "Thank you.".) (By the way, something else that encourages them is users saying
"Thank you.".)
# Who can review patches # Who can review patches
@ -33,4 +34,8 @@ To request a design review, explain your design (with or without a patch) and th
# Advanced # Advanced
Once you decide that you like reviewing tickets and you get into the habit of doing it frequently, then read this essay by Jonathan Lange on how to do it well: [Your Code Sucks and I Hate You: The Social Dynamics of Code Reviews](http://mumak.net/stuff/your-code-sucks.html). Once you decide that you like reviewing tickets and you get into the habit of doing it frequently, then read this essay by Jonathan Lange on how to do it well: [Your Code Sucks and I Hate You: The Social Dynamics of Code Reviews](http://mumak.net/stuff/your-code-sucks.html).
Two simple suggestions:
1. Say something nice about the author or their code.
2. You don't have to be extra picky.