From 60aa72e55b1fa9723c8df54e549d881964feb9f8 Mon Sep 17 00:00:00 2001 From: zooko <> Date: Sun, 3 Apr 2011 00:36:14 +0000 Subject: [PATCH] tweak how-to-review [Imported from Trac: page PatchReviewProcess, version 14] --- PatchReviewProcess.md | 15 ++++++++++----- 1 file changed, 10 insertions(+), 5 deletions(-) diff --git a/PatchReviewProcess.md b/PatchReviewProcess.md index 52f81b2..8ed436b 100644 --- a/PatchReviewProcess.md +++ b/PatchReviewProcess.md @@ -2,10 +2,11 @@ # Why review patches -We want more patches to be contributed to Tahoe-LAFS. Getting -feedback on patches encourages contributors. Patches languishing in -the "waiting to be reviewed" state discourages them. (By the way, -something else that encourages them is users saying "Thank you.".) +We want more patches to be contributed to Tahoe-LAFS. Patches +languishing in the "waiting to be reviewed" state discourages +contributors. Getting feedback on patches encourages them. +(By the way, something else that encourages them is users saying +"Thank you.".) # Who can review patches @@ -33,4 +34,8 @@ To request a design review, explain your design (with or without a patch) and th # Advanced -Once you decide that you like reviewing tickets and you get into the habit of doing it frequently, then read this essay by Jonathan Lange on how to do it well: [Your Code Sucks and I Hate You: The Social Dynamics of Code Reviews](http://mumak.net/stuff/your-code-sucks.html). \ No newline at end of file +Once you decide that you like reviewing tickets and you get into the habit of doing it frequently, then read this essay by Jonathan Lange on how to do it well: [Your Code Sucks and I Hate You: The Social Dynamics of Code Reviews](http://mumak.net/stuff/your-code-sucks.html). + +Two simple suggestions: +1. Say something nice about the author or their code. +2. You don't have to be extra picky. \ No newline at end of file