tahoe-lafs/trac-2024-07-25
2
0
Issues 1.1k Wiki Activity

move how-to-request-design-review from how-to-review-a-patch 

[Imported from Trac: page Patches, version 28]
zooko 2011-08-31 16:49:18 +00:00
parent 863b9daf43
commit 3d6d58a102
1 changed files with 6 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
Patches.md

@ -20,4 +20,9 @@ Please use a filename like `*.darcs.patch` so that Trac will display it with pro
Or without darcs you can attach a normal old unified diff. If you do that, please use a filename like `*.diff` so that Trac will display it with syntax highlighting. (If using darcs, you can generate a unified diff with `darcs whatsnew --unified`.) Or without darcs you can attach a normal old unified diff. If you do that, please use a filename like `*.diff` so that Trac will display it with syntax highlighting. (If using darcs, you can generate a unified diff with `darcs whatsnew --unified`.)
Then add the keyword `review-needed` (spelled just like that) to the Keywords field of the ticket. Then add the keyword `review-needed` (spelled just like that) to the Keywords field of the ticket.
# Design reviews
To request a design review, explain your design (with or without a patch) and then add the [design-review-needed]query:keywords~=design-review-needed&status=!closed&group=milestone tag. Completion of a design review will normally not directly result in a patch being committed. The main goal of a design review is to give the person working on the ticket confidence that there are no show-stopping issues with the approach they are taking, and to get feedback on smaller issues that are useful to take into account before doing further work on a patch.