diff --git a/Patches.md b/Patches.md index 18b73cd..d8a994e 100644 --- a/Patches.md +++ b/Patches.md @@ -20,4 +20,9 @@ Please use a filename like `*.darcs.patch` so that Trac will display it with pro Or without darcs you can attach a normal old unified diff. If you do that, please use a filename like `*.diff` so that Trac will display it with syntax highlighting. (If using darcs, you can generate a unified diff with `darcs whatsnew --unified`.) -Then add the keyword `review-needed` (spelled just like that) to the Keywords field of the ticket. \ No newline at end of file +Then add the keyword `review-needed` (spelled just like that) to the Keywords field of the ticket. + +# Design reviews + +To request a design review, explain your design (with or without a patch) and then add the [design-review-needed]query:keywords~=design-review-needed&status=!closed&group=milestone tag. Completion of a design review will normally not directly result in a patch being committed. The main goal of a design review is to give the person working on the ticket confidence that there are no show-stopping issues with the approach they are taking, and to get feedback on smaller issues that are useful to take into account before doing further work on a patch. +