tahoe-lafs/trac-2024-07-25
2
0
Issues 1.1k Wiki Activity

The tox environment seems like it should be preferred over the Makefile target 

[Imported from Trac: page Patches, version 33]
exarkun 2019-03-15 17:30:32 +00:00
parent 515fb2ce57
commit 331820e93d
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
Patches.md

@ -17,7 +17,7 @@ Now, hack at Tahoe-LAFS!
Once you think you have solved the issue run the test suite with `tox`. This ensures that you didn't accidentally break something while working on your patch. Once you think you have solved the issue run the test suite with `tox`. This ensures that you didn't accidentally break something while working on your patch.
Now that all of the existing unit tests pass, [write your own tests](https://tahoe-lafs.org/trac/tahoe-lafs/wiki/HowToWriteTests) for the ticket if they don't already exist, and make sure that they pass. Also ensure that `make pyflakes` finds no errors or warnings. Now that all of the existing unit tests pass, [write your own tests](https://tahoe-lafs.org/trac/tahoe-lafs/wiki/HowToWriteTests) for the ticket if they don't already exist, and make sure that they pass. Also ensure that `tox -e codechecks` finds no errors or warnings.
Finally, push your branch to Github and [open a pull request](https://help.github.com/articles/creating-a-pull-request). Please add the tag `review-needed` to the ticket and add a link to the pull request. If you had trouble writing unit tests for your patch, don't worry. Submit the pull request anyway and add the tag `test-needed` to the ticket. Finally, push your branch to Github and [open a pull request](https://help.github.com/articles/creating-a-pull-request). Please add the tag `review-needed` to the ticket and add a link to the pull request. If you had trouble writing unit tests for your patch, don't worry. Submit the pull request anyway and add the tag `test-needed` to the ticket.