From 331820e93d84a002f6c036cfbc39c29e970479b7 Mon Sep 17 00:00:00 2001 From: exarkun <> Date: Fri, 15 Mar 2019 17:30:32 +0000 Subject: [PATCH] The tox environment seems like it should be preferred over the Makefile target [Imported from Trac: page Patches, version 33] --- Patches.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Patches.md b/Patches.md index 6fca47c..e97102a 100644 --- a/Patches.md +++ b/Patches.md @@ -17,7 +17,7 @@ Now, hack at Tahoe-LAFS! Once you think you have solved the issue run the test suite with `tox`. This ensures that you didn't accidentally break something while working on your patch. -Now that all of the existing unit tests pass, [write your own tests](https://tahoe-lafs.org/trac/tahoe-lafs/wiki/HowToWriteTests) for the ticket if they don't already exist, and make sure that they pass. Also ensure that `make pyflakes` finds no errors or warnings. +Now that all of the existing unit tests pass, [write your own tests](https://tahoe-lafs.org/trac/tahoe-lafs/wiki/HowToWriteTests) for the ticket if they don't already exist, and make sure that they pass. Also ensure that `tox -e codechecks` finds no errors or warnings. Finally, push your branch to Github and [open a pull request](https://help.github.com/articles/creating-a-pull-request). Please add the tag `review-needed` to the ticket and add a link to the pull request. If you had trouble writing unit tests for your patch, don't worry. Submit the pull request anyway and add the tag `test-needed` to the ticket.