tahoe-lafs/trac-2024-07-25

NoServersError raised to user #1763

New issue

Open

opened 2012-06-08 15:52:30 +00:00 by zooko · 2 comments

zooko commented

2012-06-08 15:52:30 +00:00

Owner

\"/home/some/Downloads/allmydata-tahoe-1.9.0-r5844/src/allmydata/immutable/
upload.py\", line 213, in get_shareholders\x0a    raise
[NoServersError](wiki/NoServersError)(\"client gave us zero
servers\")\x0aallmydata.interfaces.NoServersError: client gave us zero

This is an example of "stack traces should never be displayed to the user". Instead, the cli should catch exceptions of this type and print out a nice explanation to the user about what is wrong and how to diagnose and fix it.

``` \"/home/some/Downloads/allmydata-tahoe-1.9.0-r5844/src/allmydata/immutable/ upload.py\", line 213, in get_shareholders\x0a raise [NoServersError](wiki/NoServersError)(\"client gave us zero servers\")\x0aallmydata.interfaces.NoServersError: client gave us zero ``` This is an example of "stack traces should never be displayed to the user". Instead, the cli should catch exceptions of this type and print out a nice explanation to the user about what is wrong and how to diagnose and fix it.

tahoe-lafs added the

labels 2012-06-08 15:52:30 +00:00

tahoe-lafs added this to the undecided milestone 2012-06-08 15:52:30 +00:00

warner commented

2012-06-08 22:05:44 +00:00

Author

Owner

so, um, what command were you running when you got this message?

The fact that we're using HTTP for everything is a bit of a drag.. either we need to format everything for a possible CLI command in the webapi, or the CLI code needs to interpret some machine-oriented HTTP response and come up with something human facing (after we've already thrown out a lot of the information). The webapi side is probably easier to do.

so, um, what command were you running when you got this message? The fact that we're using HTTP for everything is a bit of a drag.. either we need to format everything for a possible CLI command in the webapi, or the CLI code needs to interpret some machine-oriented HTTP response and come up with something human facing (after we've already thrown out a lot of the information). The webapi side is probably easier to do.

zooko commented

2012-06-09 03:29:52 +00:00

Author

Owner

Replying to warner:

so, um, what command were you running when you got this message?

Sorry. The command was:

./bin/tahoe put file.ext

Replying to [warner](/tahoe-lafs/trac-2024-07-25/issues/1763#issuecomment-130443): > so, um, what command were you running when you got this message? Sorry. The command was: ``` ./bin/tahoe put file.ext ```