tahoe-lafs/trac-2024-07-25

the WUI controls for setting the type of an uploaded file are confusing #1547

New issue

Closed

opened 2011-09-26 17:48:06 +00:00 by zooko · 13 comments

zooko commented

2011-09-26 17:48:06 +00:00

Owner

Let's replace this checkbox/radio button combo with instead a single radio button which is exactly one of "immutable", "SDMF", "MDMF (experimental)".

I propose to make this change in 1.9.

I was uploading a file and I thought that it was of type SDMF because of the radio button that was next to "SDMF" and was selected. A more careful examination shows that it was actually an immutable because of the less noticeable checkbox next to "Create mutable file" that was unselected. (See attached screen capture.) Let's replace this checkbox/radio button combo with instead a single radio button which is exactly one of "immutable", "SDMF", "MDMF (experimental)". I propose to make this change in 1.9.

tahoe-lafs added the

labels 2011-09-26 17:48:06 +00:00

tahoe-lafs added this to the 1.9.0 milestone 2011-09-26 17:48:06 +00:00

zooko commented

2011-09-26 17:48:22 +00:00

Author

Owner

Attachment screencap.png (11295 bytes) added

**Attachment** screencap.png (11295 bytes) added

screencap.png

11 KiB

davidsarah commented

2011-09-26 18:14:13 +00:00

Author

Owner

I made exactly the same mistake the first time I used this control. +1 on changing it to a single radio button for 1.9.

I also think that:

there should be more of a space between each button+label and the next (otherwise it isn't clear that the text applies to the button on its left);
there's no need for "(experimental)" in the MDMF label. In any case, the create-directory and create-file controls should be consistent in whether they include "(experimental)".

I made exactly the same mistake the first time I used this control. +1 on changing it to a single radio button for 1.9. I also think that: * there should be more of a space between each button+label and the next (otherwise it isn't clear that the text applies to the button on its left); * there's no need for "(experimental)" in the MDMF label. In any case, the create-directory and create-file controls should be consistent in whether they include "(experimental)".

warner commented

2011-09-26 18:32:34 +00:00

Author

Owner

As RM, I'm +1 for landing this in 1.9 . I don't have the time this week to make a patch, though.. can someone else do that? I can review and land it.

kevan commented

2011-09-28 17:39:38 +00:00

Author

Owner

If no one minds waiting until Saturday, I can make a patch for this.

zooko commented

2011-09-28 18:34:57 +00:00

Author

Owner

Replying to kevan:

If no one minds waiting until Saturday, I can make a patch for this.

Fine with me -- I don't intend to spend any of my time directly working on 1.9 except on !Friday/Saturday/Sunday. But I'm not the Release Manager.

Replying to [kevan](/tahoe-lafs/trac-2024-07-25/issues/1547#issuecomment-127367): > If no one minds waiting until Saturday, I can make a patch for this. Fine with me -- I don't intend to spend any of *my* time directly working on 1.9 except on !Friday/Saturday/Sunday. But I'm not the Release Manager.

davidsarah commented

2011-10-02 00:01:03 +00:00

Author

Owner

Attachment labels-on-left.png (41021 bytes) added

Labels on left

**Attachment** labels-on-left.png (41021 bytes) added Labels on left

labels-on-left.png

40 KiB

davidsarah commented

2011-10-02 00:01:34 +00:00

Author

Owner

Attachment labels-on-right.png (40824 bytes) added

Labels on right

**Attachment** labels-on-right.png (40824 bytes) added Labels on right

labels-on-right.png

40 KiB

davidsarah commented

2011-10-02 00:17:10 +00:00

Author

Owner

Attachment labels-on-right-v2.png (40928 bytes) added

Labels on right with tweaked spacing (I prefer this one)

**Attachment** labels-on-right-v2.png (40928 bytes) added Labels on right with tweaked spacing (I prefer this one)

labels-on-right-v2.png

40 KiB

davidsarah commented

2011-10-02 04:07:48 +00:00

Author

Owner

Attachment test-1547.darcs.patch (27470 bytes) added

Tests for ref #1547. Note that the tests on #1552 also need to pass in order for the fix to work.

**Attachment** test-1547.darcs.patch (27470 bytes) added Tests for ref #1547. Note that the tests on #1552 also need to pass in order for the fix to work.

test-1547.darcs.patch

27 KiB

davidsarah commented

2011-10-02 04:08:30 +00:00

Author

Owner

Attachment fix-1547.darcs.patch (37483 bytes) added

Change the file upload forms on directory and welcome pages to use a 3-way radio button to select immutable, SDMF, or MDMF. Add '(experimental)' to the label for creating an MDMF directory. Also improve the spacing of form elements. refs #1547. Depends on #1552.

**Attachment** fix-1547.darcs.patch (37483 bytes) added Change the file upload forms on directory and welcome pages to use a 3-way radio button to select immutable, SDMF, or MDMF. Add '(experimental)' to the label for creating an MDMF directory. Also improve the spacing of form elements. refs #1547. Depends on #1552.

fix-1547.darcs.patch

37 KiB

david-sarah@jacaranda.org commented

2011-10-13 16:34:14 +00:00

Author

Owner

In changeset:ac780a4148482438:

Change the file upload forms on directory and welcome pages to use a 3-way radio button to select immutable, SDMF, or MDMF. Add '(experimental)' to the label for creating an MDMF directory. Also improve the spacing of form elements. refs #1547

In changeset:ac780a4148482438: ``` Change the file upload forms on directory and welcome pages to use a 3-way radio button to select immutable, SDMF, or MDMF. Add '(experimental)' to the label for creating an MDMF directory. Also improve the spacing of form elements. refs #1547 ```

warner commented

2011-10-13 16:49:11 +00:00

Author

Owner

changeset:ac780a4148482438 should close this

tahoe-lafs added the

fixed

label 2011-10-13 16:50:07 +00:00

warner closed this issue

2011-10-13 16:50:07 +00:00

david-sarah@jacaranda.org commented

2011-10-20 20:24:28 +00:00

Author

Owner

In [5498/ticket999-S3-backend]:

Change the file upload forms on directory and welcome pages to use a 3-way radio button to select immutable, SDMF, or MDMF. Add '(experimental)' to the label for creating an MDMF directory. Also improve the spacing of form elements. refs #1547

In [5498/ticket999-S3-backend]: ``` Change the file upload forms on directory and welcome pages to use a 3-way radio button to select immutable, SDMF, or MDMF. Add '(experimental)' to the label for creating an MDMF directory. Also improve the spacing of form elements. refs #1547 ```