tahoe-lafs/trac-2024-07-25

zero-byte MDMF reads should not fetch any segments #1518

New issue

Open

opened 2011-08-31 05:38:57 +00:00 by warner · 1 comment

warner commented

2011-08-31 05:38:57 +00:00

Owner

A minor leftover from #1512 is a low-yield performance improvement: if somebody does a zero-byte read, the code should return without actually fetching any segments. The current code (as of changeset:32e30c9023479e3c) fetches the first segment, then throws away all of its data.

This ought to be a two-liner: it's probably enough to return defer.succeed(something) without ever even talking to the IConsumer.

A minor leftover from #1512 is a low-yield performance improvement: if somebody does a zero-byte read, the code should return without actually fetching any segments. The current code (as of changeset:32e30c9023479e3c) fetches the first segment, then throws away all of its data. This ought to be a two-liner: it's probably enough to return `defer.succeed(something)` without ever even talking to the `IConsumer`.

tahoe-lafs added the

labels 2011-08-31 05:38:57 +00:00

tahoe-lafs added this to the eventually milestone 2011-08-31 05:38:57 +00:00

warner commented

2015-08-18 16:41:33 +00:00

Author

Owner

I think I might have fixed this in [89e9076c4], but it needs closer examination to be sure.

I *think* I might have fixed this in [89e9076c4], but it needs closer examination to be sure.

Sign in to join this conversation.

No labels

LeastAuthority.com automation

cannot reproduce

code-frontend-cli

code-frontend-ftp-sftp

code-frontend-magic-folder

code-frontend-web

code-peerselection

dev-infrastructure

somebody else's problem

was already fixed

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: tahoe-lafs/trac-2024-07-25#1518

No description provided.