tahoe-lafs/trac-2024-07-25

zero-length reads break new mutable downloader #1512

New issue

Closed

opened 2011-08-27 23:55:46 +00:00 by warner · 3 comments

warner commented

2011-08-27 23:55:46 +00:00

Owner

The new mutable downloader, landed as part of MDMF in #393, has problems when asked to download zero bytes: it returns more than zero bytes.

We have tests in test_mutable.Version to catch this, currently disabled.

This is a blocker for 1.9beta

The new mutable downloader, landed as part of MDMF in #393, has problems when asked to download zero bytes: it returns more than zero bytes. We have tests in `test_mutable.Version` to catch this, currently disabled. This is a blocker for 1.9beta

tahoe-lafs added the

labels 2011-08-27 23:55:46 +00:00

tahoe-lafs added this to the 1.9.0 milestone 2011-08-27 23:55:46 +00:00

kevan commented

2011-08-30 21:09:41 +00:00

Author

Owner

Attachment fix-zero-length-reads.darcspatch (10049 bytes) added

fix zero-length reads; enable tests of zero-length reads

**Attachment** fix-zero-length-reads.darcspatch (10049 bytes) added fix zero-length reads; enable tests of zero-length reads

fix-zero-length-reads.darcspatch

9.8 KiB

Kevan Carstensen <kevan@isnotajoke.com> commented

2011-08-31 05:10:23 +00:00

Author

Owner

In changeset:32e30c9023479e3c:

mutable/retrieve: handle the case where self._read_length is 0.

Note that the downloader will still fetch a segment for a zero-length
read, which is wasteful. Fixing that isn't specifically required to fix
#1512, but it should probably be fixed before 1.9.

In changeset:32e30c9023479e3c: ``` mutable/retrieve: handle the case where self._read_length is 0. Note that the downloader will still fetch a segment for a zero-length read, which is wasteful. Fixing that isn't specifically required to fix #1512, but it should probably be fixed before 1.9. ```

tahoe-lafs added the

label 2011-08-31 05:10:23 +00:00

Kevan Carstensen <kevan@isnotajoke.com> closed this issue

2011-08-31 05:10:23 +00:00

warner commented

2011-08-31 05:40:33 +00:00

Author

Owner

I agree with the comment that it'd be nice to improve efficiency of zero-byte reads by not actually downloading any segments (I've opened #1518 to track that), but I'm not going to hold up 1.9 for that.. correctness is sufficient.

I agree with the comment that it'd be nice to improve efficiency of zero-byte reads by not actually downloading any segments (I've opened #1518 to track that), but I'm not going to hold up 1.9 for that.. correctness is sufficient.

Sign in to join this conversation.

No labels

LeastAuthority.com automation

cannot reproduce

code-frontend-cli

code-frontend-ftp-sftp

code-frontend-magic-folder

code-frontend-web

code-peerselection

dev-infrastructure

somebody else's problem

was already fixed

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: tahoe-lafs/trac-2024-07-25#1512

No description provided.