tahoe-lafs/trac-2024-07-25

release 1.8.2 #1306

New issue

Closed

opened 2011-01-14 04:56:34 +00:00 by davidsarah · 11 comments

davidsarah commented

2011-01-14 04:56:34 +00:00

Owner

No description provided.

tahoe-lafs added the

labels 2011-01-14 04:56:34 +00:00

tahoe-lafs added this to the 1.8.2 milestone 2011-01-14 04:56:34 +00:00

zooko commented

2011-01-15 07:32:38 +00:00

Author

Owner

+1 on changeset:33786a6d55661cea! Please push it into trunk! :-) (And watch what happens to all the Supported Builders before and after.)

david-sarah@jacaranda.org commented

2011-01-21 08:06:22 +00:00

Author

Owner

In changeset:f3b4f4181cba3dde:

src/allmydata/_auto_deps.py: 'pysqlite.dbapi2' module should have been 'pysqlite2.dbapi2'. refs #1306

In changeset:f3b4f4181cba3dde: ``` src/allmydata/_auto_deps.py: 'pysqlite.dbapi2' module should have been 'pysqlite2.dbapi2'. refs #1306 ```

david-sarah@jacaranda.org commented

2011-01-22 04:58:08 +00:00

Author

Owner

In changeset:cb02adb11027165e:

Don't put debugging information in 'My versions' section of the Welcome page. Also remove the extra blank line between version and command output when --version[-and-path] is used. refs #1306

In changeset:cb02adb11027165e: ``` Don't put debugging information in 'My versions' section of the Welcome page. Also remove the extra blank line between version and command output when --version[-and-path] is used. refs #1306 ```

zooko commented

2011-01-22 07:13:33 +00:00

Author

Owner

Reviewed: changeset:c8ccb297fa7f499d, changeset:0c51ce3d8935d170, changeset:74aba7dd264083e0, changeset:f84f2aa98777c10d, changeset:8f4ae53f391429ed, changeset:ae3373188cc223c9, changeset:a008c79762b695d7, changeset:6d6f0edc3698e1ab, changeset:3c161c9a96dd09fe, changeset:3eadc8a05375656f (yay! I love this patch!), changeset:cb02adb11027165e.

Question about changeset:39eede4217997b22: why is quotemarks=False used in the first call to quote_output() and not in the others?

davidsarah commented

2011-01-22 07:43:00 +00:00

Author

Owner

Replying to zooko:

Question about changeset:39eede4217997b22: why is quotemarks=False used in the first call to quote_output() and not in the others?

Just because there weren't any quotes in the existing "No such child: %s".

Replying to [zooko](/tahoe-lafs/trac-2024-07-25/issues/1306#issuecomment-123619): > Question about changeset:39eede4217997b22: why is `quotemarks=False` used in the first call to `quote_output()` and not in the others? Just because there weren't any quotes in the existing `"No such child: %s"`.

zooko commented

2011-01-28 15:40:05 +00:00

Author

Owner

I will attach some documentation patches.

zooko commented

2011-01-28 15:47:13 +00:00

Author

Owner

Attachment docs-for-1.8.2.darcs.patch (6479 bytes) added

**Attachment** docs-for-1.8.2.darcs.patch (6479 bytes) added

docs-for-1.8.2.darcs.patch

6.3 KiB

davidsarah commented

2011-01-30 05:06:20 +00:00

Author

Owner

Replying to zooko:

I will attach some documentation patches.

Why is the allmydata.~~com~~org -> tahoe-lafs.org patch doing the reverse change in some places, only to then change it back?

I'm not sure I trust replace patches at all. Just by looking at the patch, I can't see whether they're correct, or whether they're changing stuff that should be left as-is. In particular I don't really see the need to change references to allmydata.org for earlier entries in NEWS, for example. Those entries should be immutable -- or perhaps we should add a note "Links to allmydata.org below should now be tahoe-lafs.org."

Replying to [zooko](/tahoe-lafs/trac-2024-07-25/issues/1306#issuecomment-123621): > I will attach some documentation patches. Why is the allmydata.~~com~~org -> tahoe-lafs.org patch doing the reverse change in some places, only to then change it back? I'm not sure I trust replace patches at all. Just by looking at the patch, I can't see whether they're correct, or whether they're changing stuff that should be left as-is. In particular I don't really see the need to change references to allmydata.org for earlier entries in NEWS, for example. Those entries should be immutable -- or perhaps we should add a note "Links to allmydata.org below should now be tahoe-lafs.org."

warner commented

2011-01-31 02:14:51 +00:00

Author

Owner

Attachment docs.diff (5821 bytes) added

last-minute docs changes for double-checking

**Attachment** docs.diff (5821 bytes) added last-minute docs changes for double-checking

docs.diff

5.7 KiB

warner commented

2011-01-31 07:18:16 +00:00

Author