'tahoe create-alias ALIAS:' and 'tahoe add-alias ALIAS: DIRCAP' (with trailing colon) should work #1305

Closed
opened 2011-01-14 03:17:04 +00:00 by davidsarah · 11 comments
davidsarah commented 2011-01-14 03:17:04 +00:00
Owner

tahoe create-alias and tahoe add-alias should accept a trailing colon. Also user errors (including a colon or space in the alias name) should not be reported by an assert.

`tahoe create-alias` and `tahoe add-alias` should accept a trailing colon. Also user errors (including a colon or space in the alias name) should not be reported by an assert.
tahoe-lafs added the
code-frontend-cli
minor
defect
1.8.1
labels 2011-01-14 03:17:04 +00:00
tahoe-lafs added this to the 1.8.2 milestone 2011-01-14 03:17:04 +00:00
tahoe-lafs changed title from 'tahoe create-alias ALIAS:' and 'tahoe add-alias ALIAS:' (with trailing colon) should work to 'tahoe create-alias ALIAS:' and 'tahoe add-alias ALIAS: DIRCAP' (with trailing colon) should work 2011-01-14 03:19:30 +00:00
davidsarah commented 2011-01-14 04:06:48 +00:00
Author
Owner

Attachment test-1305.darcs.patch (13944 bytes) added

CLI: tests for ref #1305

**Attachment** test-1305.darcs.patch (13944 bytes) added CLI: tests for ref #1305
davidsarah commented 2011-01-14 04:08:09 +00:00
Author
Owner

This would be an easy patch for someone new to Tahoe to review.

This would be an easy patch for someone new to Tahoe to review.
davidsarah commented 2011-01-14 04:18:00 +00:00
Author
Owner

Attachment fix-1305.darcs.patch (15829 bytes) added

CLI: make 'tahoe create-alias' and 'tahoe add-alias' accept a trailing colon on the new alias name (v2, minor change not to rely on implicit Unicode conversion). Includes doc changes and news; tests in a separate patch. fixes #1305

**Attachment** fix-1305.darcs.patch (15829 bytes) added CLI: make 'tahoe create-alias' and 'tahoe add-alias' accept a trailing colon on the new alias name (v2, minor change not to rely on implicit Unicode conversion). Includes doc changes and news; tests in a separate patch. fixes #1305
davidsarah commented 2011-01-14 04:36:23 +00:00
Author
Owner

Attachment test-1305.darcs.2.patch (14042 bytes) added

CLI: tests for ref #1305 (v2, remove spurious extra arg to create-alias in test)

**Attachment** test-1305.darcs.2.patch (14042 bytes) added CLI: tests for ref #1305 (v2, remove spurious extra arg to create-alias in test)
david-sarah@jacaranda.org commented 2011-01-14 06:41:09 +00:00
Author
Owner

In [4929/ticket1306]:

CLI: make 'tahoe create-alias' and 'tahoe add-alias' accept a trailing colon on the new alias name (v2, minor change not to rely on implicit Unicode conversion). Includes doc changes and news; tests in a separate patch. fixes #1305
In [4929/ticket1306]: ``` CLI: make 'tahoe create-alias' and 'tahoe add-alias' accept a trailing colon on the new alias name (v2, minor change not to rely on implicit Unicode conversion). Includes doc changes and news; tests in a separate patch. fixes #1305 ```
tahoe-lafs added the
fixed
label 2011-01-14 06:41:09 +00:00
david-sarah@jacaranda.org closed this issue 2011-01-14 06:41:09 +00:00
davidsarah commented 2011-01-14 08:44:31 +00:00
Author
Owner

Not fixed because it hasn't been applied on trunk.

Not fixed because it hasn't been applied on trunk.
tahoe-lafs removed the
fixed
label 2011-01-14 08:44:31 +00:00
davidsarah reopened this issue 2011-01-14 08:44:31 +00:00
zooko commented 2011-01-14 23:28:57 +00:00
Author
Owner

Replying to davidsarah:

This would be an easy patch for someone new to Tahoe to review.

Is this supposed to have the review-needed tag now?

Replying to [davidsarah](/tahoe-lafs/trac-2024-07-25/issues/1305#issuecomment-123595): > This would be an easy patch for someone new to Tahoe to review. Is this supposed to have the `review-needed` tag now?
davidsarah commented 2011-01-15 00:21:57 +00:00
Author
Owner

Replying to [zooko]comment:5:

Is this supposed to have the review-needed tag now?

Oops, I thought I'd already added one.

Replying to [zooko]comment:5: > Is this supposed to have the `review-needed` tag now? Oops, I thought I'd already added one.
warner commented 2011-01-17 09:55:21 +00:00
Author
Owner

looks great. pushing now.

looks great. pushing now.
david-sarah@jacaranda.org commented 2011-01-17 09:55:44 +00:00
Author
Owner

In changeset:f10a2c0902549684:

CLI: make 'tahoe create-alias' and 'tahoe add-alias' accept a trailing colon on the new alias name (v2, minor change not to rely on implicit Unicode conversion). Includes doc changes and news; tests in a separate patch. fixes #1305
In changeset:f10a2c0902549684: ``` CLI: make 'tahoe create-alias' and 'tahoe add-alias' accept a trailing colon on the new alias name (v2, minor change not to rely on implicit Unicode conversion). Includes doc changes and news; tests in a separate patch. fixes #1305 ```
tahoe-lafs added the
fixed
label 2011-01-17 09:55:44 +00:00
david-sarah@jacaranda.org closed this issue 2011-01-17 09:55:44 +00:00
davidsarah commented 2011-01-17 22:21:52 +00:00
Author
Owner

Tests in changeset:5a3acc05b73095b8.

Tests in changeset:5a3acc05b73095b8.
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: tahoe-lafs/trac-2024-07-25#1305
No description provided.