remove unmaintained Mac and Windows apps #1282

Closed
opened 2010-12-26 00:40:14 +00:00 by davidsarah · 15 comments
davidsarah commented 2010-12-26 00:40:14 +00:00
Owner

The Mac OS X GUI application in source:mac, and the Windows GUI application in source:windows, are unmaintained, untested, and depend on the allmydata.com user account system which is no longer in operation. They should be either removed from the tree, or fixed to not depend on the allmydata.com account system.

(I think these apps are not helpful for allowing allmydata.com customers using Mac OS X or Windows to retrieve their data; please correct me if I'm wrong on that point.)

Both of these apps depend on source:src/allmydata/gui/confwiz.py.

(Note when reading up to comment:123192 -- this ticket was originally about only the Mac app.)

The Mac OS X GUI application in source:mac, and the Windows GUI application in source:windows, are unmaintained, untested, and depend on the allmydata.com user account system which is no longer in operation. They should be either removed from the tree, or fixed to not depend on the allmydata.com account system. (I think these apps are not helpful for allowing allmydata.com customers using Mac OS X or Windows to retrieve their data; please correct me if I'm wrong on that point.) Both of these apps depend on source:src/allmydata/gui/confwiz.py. (Note when reading up to [comment:123192](/tahoe-lafs/trac-2024-07-25/issues/1282#issuecomment-123192) -- this ticket was originally about only the Mac app.)
tahoe-lafs added the
code
major
defect
1.8.1
labels 2010-12-26 00:40:14 +00:00
tahoe-lafs added this to the 1.9.0 milestone 2010-12-26 00:40:14 +00:00
warner commented 2010-12-26 00:51:53 +00:00
Author
Owner

good point. maybe we should move it to contrib/ to serve as reference material? It'd be nice if the code were usable to somebody in the future, to build a new GUI.

good point. maybe we should move it to contrib/ to serve as reference material? It'd be nice if the code were usable to somebody in the future, to build a new GUI.
davidsarah commented 2010-12-26 02:22:29 +00:00
Author
Owner

Replying to warner:

good point. maybe we should move it to contrib/ to serve as reference material? It'd be nice if the code were usable to somebody in the future, to build a new GUI.

-1 on moving it to contrib/, since anyone building a new GUI can just check out a revision before the removal (e.g. the allmydata-tahoe-1.8.1 tag).

Note that changeset changeset:00aa75d1e8b8b188 moved some of the FUSE-related code from the Mac app to become source:contrib/fuse/impl_c/blackmatch.py. For future historians, here are some notes that might be useful:

  • when invoked with command-line options, the Mac app would run the tahoe CLI, but with an extra tahoe fuse subcommand. This was implemented at source:mac/allmydata_tahoe.py@2186#L25. The tahoefuse module imported there is actually blackmatch.py (copied by the build process).
  • the options passed to tahoe fuse by the GUI app when mounting a filesystem are given at source:src/allmydata/gui/macapp.py@4329#L482.
Replying to [warner](/tahoe-lafs/trac-2024-07-25/issues/1282#issuecomment-123190): > good point. maybe we should move it to contrib/ to serve as reference material? It'd be nice if the code were usable to somebody in the future, to build a new GUI. -1 on moving it to contrib/, since anyone building a new GUI can just check out a revision before the removal (e.g. the allmydata-tahoe-1.8.1 tag). Note that changeset changeset:00aa75d1e8b8b188 moved some of the FUSE-related code from the Mac app to become source:contrib/fuse/impl_c/blackmatch.py. For future historians, here are some notes that might be useful: - when invoked with command-line options, the Mac app would run the `tahoe` CLI, but with an extra `tahoe fuse` subcommand. This was implemented at source:mac/allmydata_tahoe.py@2186#L25. The `tahoefuse` module imported there is actually `blackmatch.py` (copied by the build process). - the options passed to `tahoe fuse` by the GUI app when mounting a filesystem are given at source:src/allmydata/gui/macapp.py@4329#L482.
davidsarah commented 2010-12-26 02:40:26 +00:00
Author
Owner

Attachment remove-mac-app.darcs.patch (217719 bytes) added

Remove unmaintained Mac GUI app.

**Attachment** remove-mac-app.darcs.patch (217719 bytes) added Remove unmaintained Mac GUI app.
davidsarah commented 2010-12-26 03:30:49 +00:00
Author
Owner

Attachment remove-mac-app.darcs.2.patch (218551 bytes) added

Remove unmaintained Mac GUI app. This version also removes the Makefile targets.

**Attachment** remove-mac-app.darcs.2.patch (218551 bytes) added Remove unmaintained Mac GUI app. This version also removes the Makefile targets.
tahoe-lafs changed title from remove unmaintained Mac app to remove unmaintained Mac and Windows apps 2010-12-26 03:43:46 +00:00
davidsarah commented 2010-12-26 03:52:00 +00:00
Author
Owner

I hadn't realized that the code in source:src/allmydata/gui was portable between Mac and Windows (and other platforms supporting wxWindows). It does still depend on the allmydata.com account system, but maybe we should be trying to remove that dependency rather than removing these apps.

I hadn't realized that the code in source:src/allmydata/gui was portable between Mac and Windows (and other platforms supporting wxWindows). It does still depend on the allmydata.com account system, but maybe we should be trying to remove that dependency rather than removing these apps.
tahoe-lafs modified the milestone from 1.9.0 to undecided 2010-12-26 03:52:00 +00:00
davidsarah commented 2010-12-26 03:58:14 +00:00
Author
Owner

In particular, windows/tahoe.py source:windows/tahoesvc.py includes code to run a storage server as a Windows service. That seems worth saving (and perhaps including as an option to tahoe run, or the default behaviour of tahoe start on Windows).

In particular, ~~windows/tahoe.py~~ source:windows/tahoesvc.py includes code to run a storage server as a Windows service. That seems worth saving (and perhaps including as an option to `tahoe run`, or the default behaviour of `tahoe start` on Windows).
tahoe-lafs changed title from remove unmaintained Mac and Windows apps to remove or fix unmaintained Mac and Windows apps 2010-12-26 04:04:45 +00:00
davidsarah commented 2010-12-26 04:53:27 +00:00
Author
Owner

After looking more closely at source:src/allmydata/gui/confwiz.py, it is almost entirely concerned with allmydata.com stuff that is no longer useful.

This code does encode some lore about how to create stub Mac and Windows GUI apps. I'm not sure this is worth keeping in the tree without any useful GUI code to run.

I'll move source:windows/tahoesvc.py into source:src/allmydata/windows in order to retain its revision history. It will need more work to be usable, because it currently depends on the tahoe process being an executable created by py2exe (http://agiletesting.blogspot.com/2005/09/running-python-script-as-windows.html says that it is possible to run a batch file as a service, though).

After looking more closely at source:src/allmydata/gui/confwiz.py, it is almost entirely concerned with allmydata.com stuff that is no longer useful. This code does encode some lore about how to create stub Mac and Windows GUI apps. I'm not sure this is worth keeping in the tree without any useful GUI code to run. I'll move source:windows/tahoesvc.py into source:src/allmydata/windows in order to retain its revision history. It will need more work to be usable, because it currently depends on the tahoe process being an executable created by `py2exe` (<http://agiletesting.blogspot.com/2005/09/running-python-script-as-windows.html> says that it is possible to run a batch file as a service, though).
davidsarah commented 2010-12-26 04:54:48 +00:00
Author
Owner

Attachment remove-mac-and-windows-apps.darcs.patch (363842 bytes) added

Remove unmaintained Mac and Windows GUI apps. Supercedes previous patches.

**Attachment** remove-mac-and-windows-apps.darcs.patch (363842 bytes) added Remove unmaintained Mac and Windows GUI apps. Supercedes previous patches.
tahoe-lafs modified the milestone from undecided to 1.9.0 2010-12-26 04:59:35 +00:00
tahoe-lafs changed title from remove or fix unmaintained Mac and Windows apps to remove unmaintained Mac and Windows apps 2010-12-26 05:44:27 +00:00
Zarutian commented 2011-01-02 04:41:30 +00:00
Author
Owner

I say we remove those two apps as their code would continue to exists in the source tree as a earlier revisions. Anyone who wants to write comperable GUI app can go spelunking. Perhaps a pointer to the last revision containing them can be added in the documentation to help potential future GUI app writers.

I say we remove those two apps as their code would continue to exists in the source tree as a earlier revisions. Anyone who wants to write comperable GUI app can go spelunking. Perhaps a pointer to the last revision containing them can be added in the documentation to help potential future GUI app writers.
david-sarah@jacaranda.org commented 2011-01-02 05:24:57 +00:00
Author
Owner

In changeset:195ddbcf7cde56d0:

Remove unmaintained Mac GUI app. fixes #1282
In changeset:195ddbcf7cde56d0: ``` Remove unmaintained Mac GUI app. fixes #1282 ```
tahoe-lafs added the
fixed
label 2011-01-02 05:24:57 +00:00
david-sarah@jacaranda.org closed this issue 2011-01-02 05:24:57 +00:00
david-sarah@jacaranda.org commented 2011-01-02 05:24:57 +00:00
Author
Owner

In changeset:89c71a8c2c72e87b:

NEWS: remove unmaintained Mac GUI app. refs #1282
In changeset:89c71a8c2c72e87b: ``` NEWS: remove unmaintained Mac GUI app. refs #1282 ```
david-sarah@jacaranda.org commented 2011-01-02 05:24:58 +00:00
Author
Owner

In changeset:2182c9084ed93b8e:

Remove the Makefile targets relating to the Mac GUI app. refs #1282
In changeset:2182c9084ed93b8e: ``` Remove the Makefile targets relating to the Mac GUI app. refs #1282 ```
david-sarah@jacaranda.org commented 2011-01-02 05:24:58 +00:00
Author
Owner

In changeset:3132c9b593a6664b:

Remove unmaintained Windows GUI app, except for windows/tahoesvc.py which is moved to src/allmydata/windows. refs #1282
In changeset:3132c9b593a6664b: ``` Remove unmaintained Windows GUI app, except for windows/tahoesvc.py which is moved to src/allmydata/windows. refs #1282 ```
david-sarah@jacaranda.org commented 2011-01-02 05:24:58 +00:00
Author
Owner

In changeset:2c099ffa0d7412ab:

Move dependency imports from windows/depends.py (which has gone away) into src/allmydata/windows/tahoesvc.py. Also fix a pyflakes warning, and change the service display name from 'Allmydata Tahoe Node' to 'Tahoe-LAFS node'. refs #1282
In changeset:2c099ffa0d7412ab: ``` Move dependency imports from windows/depends.py (which has gone away) into src/allmydata/windows/tahoesvc.py. Also fix a pyflakes warning, and change the service display name from 'Allmydata Tahoe Node' to 'Tahoe-LAFS node'. refs #1282 ```
david-sarah@jacaranda.org commented 2011-01-02 05:24:59 +00:00
Author
Owner

In changeset:e3974d125aacbb6f:

NEWS: update entry for removal of Mac and Windows apps. refs #1282
In changeset:e3974d125aacbb6f: ``` NEWS: update entry for removal of Mac and Windows apps. refs #1282 ```
tahoe-lafs modified the milestone from 1.9.0 to 1.8.2 2011-01-06 00:41:25 +00:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: tahoe-lafs/trac-2024-07-25#1282
No description provided.