Also, random_unicode seems more general than it needs to be. (It would probably be slightly simpler to choose random unicode code points, rather than to choose a random UTF-8 encoding for each character and loop until it is valid, since the encoded length doesn't appear to be critical.)

Otherwise looks fine. Please keep this ticket open so I can attach my own cleanup patches :-)

Please wrap the lines longer than about 100 chars. Also, `random_unicode` seems more general than it needs to be. (It would probably be slightly simpler to choose random unicode code points, rather than to choose a random UTF-8 encoding for each character and loop until it is valid, since the encoded length doesn't appear to be critical.) Otherwise looks fine. Please keep this ticket open so I can attach my own cleanup patches :-)

zooko commented

2010-07-21 16:51:23 +00:00

Author

Owner

Replying to davidsarah:

Please wrap the lines longer than about 100 chars.

Okay (grumble).

Also, random_unicode seems more general than it needs to be. (It would probably be slightly simpler to choose random unicode code points,

Yeah, for the purposes of this benchmark, it could even just be a random ascii string or something. How would one choose random unicode code points other than the way random_unicode() does it?

Replying to [davidsarah](/tahoe-lafs/trac-2024-07-25/issues/1131#issuecomment-120464): > Please wrap the lines longer than about 100 chars. Okay (*grumble*). > Also, `random_unicode` seems more general than it needs to be. (It would probably be slightly simpler to choose random unicode code points, Yeah, for the purposes of this benchmark, it could even just be a random ascii string or something. How would one choose random unicode code points other than the way `random_unicode()` does it?

zooko commented

2010-07-23 05:34:10 +00:00

Author

Owner

Removing review-needed. I'll line-wrap, probably leave the silly random_unicode() as is, and commit the patch. Leaving this ticket open for other post-1.7.1 cleanup patches. :-)

Removing review-needed. I'll line-wrap, probably leave the silly `random_unicode()` as is, and commit the patch. Leaving this ticket open for other post-1.7.1 cleanup patches. :-)

davidsarah commented

2010-08-02 04:37:54 +00:00

Author

Owner

There's an uncommented print statement in is_happy_enough. Otherwise fine.

There's an uncommented print statement in `is_happy_enough`. Otherwise fine.

zooko commented

2010-08-02 06:46:16 +00:00

Author

Owner

Below is a patch to reformat lines to < 100 chars and to tidy up logging in immutable/upload.py.

zooko commented