tahoe-lafs/trac-2024-07-25
2
0
Issues 1.1k Wiki Activity

Support for FreeBSD > 6 is missing from iputil.py #1098

New issue
Closed
opened 2010-06-25 08:54:29 +00:00 by francois · 6 comments
francois commented 2010-06-25 08:54:29 +00:00
Owner
Copy link

On tahoe-dev, Randy Bush reported the following error when running a Tahoe node under FreeBSD 8.0.

2010-06-25 06:43:15+0000 [-] Unhandled Error
        Traceback (most recent call last):
          File "/usr/local/src/net/allmydata-tahoe-1.7.0/support/lib/python2.5/site-packages/foolscap-0.5.1-py2.5.egg/foolscap/eventual.py", line 26, in _turn
            cb(*args, **kwargs)
          File "/usr/local/src/net/allmydata-tahoe-1.7.0/src/allmydata/node.py", line 259, in _startService
            d.addCallback(lambda res: iputil.get_local_addresses_async())
          File "/usr/local/src/net/allmydata-tahoe-1.7.0/Twisted-10.0.0-py2.5-freebsd-8.0-STABLE-amd64.egg/twisted/internet/defer.py", line 224, in addCallback
            callbackKeywords=kw)
          File "/usr/local/src/net/allmydata-tahoe-1.7.0/Twisted-10.0.0-py2.5-freebsd-8.0-STABLE-amd64.egg/twisted/internet/defer.py", line 213, in addCallbacks
            self._runCallbacks()
        --- <exception caught here> ---
          File "/usr/local/src/net/allmydata-tahoe-1.7.0/Twisted-10.0.0-py2.5-freebsd-8.0-STABLE-amd64.egg/twisted/internet/defer.py", line 371, in _runCallbacks
            self.result = callback(self.result, *args, **kw)
          File "/usr/local/src/net/allmydata-tahoe-1.7.0/src/allmydata/node.py", line 259, in <lambda>
            d.addCallback(lambda res: iputil.get_local_addresses_async())
          File "/usr/local/src/net/allmydata-tahoe-1.7.0/src/allmydata/util/iputil.py", line 94, in get_local_addresses_async
            d = _find_addresses_via_config()
          File "/usr/local/src/net/allmydata-tahoe-1.7.0/src/allmydata/util/iputil.py", line 242, in _find_addresses_via_config
            raise UnsupportedPlatformError(sys.platform)
        allmydata.util.iputil.UnsupportedPlatformError: freebsd8
On tahoe-dev, Randy Bush reported the following error when running a Tahoe node under FreeBSD 8.0. ``` 2010-06-25 06:43:15+0000 [-] Unhandled Error Traceback (most recent call last): File "/usr/local/src/net/allmydata-tahoe-1.7.0/support/lib/python2.5/site-packages/foolscap-0.5.1-py2.5.egg/foolscap/eventual.py", line 26, in _turn cb(*args, **kwargs) File "/usr/local/src/net/allmydata-tahoe-1.7.0/src/allmydata/node.py", line 259, in _startService d.addCallback(lambda res: iputil.get_local_addresses_async()) File "/usr/local/src/net/allmydata-tahoe-1.7.0/Twisted-10.0.0-py2.5-freebsd-8.0-STABLE-amd64.egg/twisted/internet/defer.py", line 224, in addCallback callbackKeywords=kw) File "/usr/local/src/net/allmydata-tahoe-1.7.0/Twisted-10.0.0-py2.5-freebsd-8.0-STABLE-amd64.egg/twisted/internet/defer.py", line 213, in addCallbacks self._runCallbacks() --- <exception caught here> --- File "/usr/local/src/net/allmydata-tahoe-1.7.0/Twisted-10.0.0-py2.5-freebsd-8.0-STABLE-amd64.egg/twisted/internet/defer.py", line 371, in _runCallbacks self.result = callback(self.result, *args, **kw) File "/usr/local/src/net/allmydata-tahoe-1.7.0/src/allmydata/node.py", line 259, in <lambda> d.addCallback(lambda res: iputil.get_local_addresses_async()) File "/usr/local/src/net/allmydata-tahoe-1.7.0/src/allmydata/util/iputil.py", line 94, in get_local_addresses_async d = _find_addresses_via_config() File "/usr/local/src/net/allmydata-tahoe-1.7.0/src/allmydata/util/iputil.py", line 242, in _find_addresses_via_config raise UnsupportedPlatformError(sys.platform) allmydata.util.iputil.UnsupportedPlatformError: freebsd8 ```
tahoe-lafs added the
unknown
minor
defect
1.7.0
 labels 2010-06-25 08:54:29 +00:00
tahoe-lafs added this to the 1.7.1 milestone 2010-06-25 08:54:29 +00:00
francois commented 2010-06-25 09:29:19 +00:00
Author
Owner
Copy link

Attachment iputil-freebsd.diff.dpatch (47066 bytes) added

**Attachment** iputil-freebsd.diff.dpatch (47066 bytes) added
iputil-freebsd.diff.dpatch
46 KiB
francois commented 2010-06-25 09:42:15 +00:00
Author
Owner
Copy link

I don't see any easy way to implement meaningful tests for this change. It's probably better to have a new buildbot running a recent FreeBSD version.

What do you think?

I don't see any easy way to implement meaningful tests for this change. It's probably better to have a new buildbot running a recent FreeBSD version. What do you think?
zooko commented 2010-06-26 13:34:48 +00:00
Author
Owner
Copy link

I would be willing to apply this based on Randy Bush's FreeBSD 8 buildbot.

It would be even cooler to do a "mock out the underlying platform" hack like the way you, François, wrote portable unit tests of your unicode work. The unit tests could make sys.platform say "FreeBSD10" or something and then when iputil.py calls getProcessOutput() the test could patch out getProcessOutput() to return a sensible thing that looks like the output of "ifconfig -a" on FreeBSD 10.

I would be willing to apply this based on Randy Bush's FreeBSD 8 buildbot. It would be even cooler to do a "mock out the underlying platform" hack like the way you, François, wrote portable unit tests of your unicode work. The unit tests could make `sys.platform` say "FreeBSD10" or something and then when iputil.py calls `getProcessOutput()` the test could patch out `getProcessOutput()` to return a sensible thing that looks like the output of "ifconfig -a" on FreeBSD 10.
francois commented 2010-06-28 10:07:07 +00:00
Author
Owner
Copy link

Replying to zooko:

It would be even cooler to do a "mock out the underlying platform" hack like the way you, François, wrote portable unit tests of your unicode work. The unit tests could make sys.platform say "FreeBSD10" or something and then when iputil.py calls getProcessOutput() the test could patch out getProcessOutput() to return a sensible thing that looks like the output of "ifconfig -a" on FreeBSD 10.

Zooko, I knew you'd be saying that ;)

I'll have a look into that.

Replying to [zooko](/tahoe-lafs/trac-2024-07-25/issues/1098#issuecomment-119926): > It would be even cooler to do a "mock out the underlying platform" hack like the way you, François, wrote portable unit tests of your unicode work. The unit tests could make `sys.platform` say "FreeBSD10" or something and then when iputil.py calls `getProcessOutput()` the test could patch out `getProcessOutput()` to return a sensible thing that looks like the output of "ifconfig -a" on FreeBSD 10. Zooko, I knew you'd be saying that ;) I'll have a look into that.
davidsarah commented 2010-07-17 05:38:15 +00:00
Author
Owner
Copy link

This seems like a very safe patch that should be applied for 1.7.1, regardless of the absence of tests.

This seems like a very safe patch that should be applied for 1.7.1, regardless of the absence of tests.
zooko commented 2010-07-18 02:56:56 +00:00
Author
Owner
Copy link

Oh all right. For the record, I still want a deterministic mockery-based unit test and I still want Randy's FreeBSD buildslave to go green:

http://tahoe-lafs.org/buildbot/waterfall?show=Randy%20FreeBSD-amd64

But I guess this patch is extremely unlikely to cause a regression. :-)

applied in changeset:968edfda119cb29c. Thanks!

Oh all right. For the record, I still want a deterministic mockery-based unit test and I still want Randy's FreeBSD buildslave to go green: <http://tahoe-lafs.org/buildbot/waterfall?show=Randy%20FreeBSD-amd64> But I guess this patch is extremely unlikely to cause a regression. :-) applied in changeset:968edfda119cb29c. Thanks!
tahoe-lafs added the
fixed
 label 2010-07-18 02:56:56 +00:00
zooko closed this issue 2010-07-18 02:56:56 +00:00
Sign in to join this conversation.
No Branch/Tag specified
Branches Tags
No results found.
No results found.
Labels
Clear labels   
0.2.0

   
0.3.0

   
0.4.0

   
0.5.0

   
0.5.1

   
0.6.0

   
0.6.1

   
0.7.0

   
0.8.0

   
0.9.0

   
1.0.0

   
1.1.0

   
1.10.0

   
1.10.1

   
1.10.2

   
1.10a2

   
1.11.0

   
1.12.0

   
1.12.1

   
1.13.0

   
1.14.0

   
1.15.0

   
1.15.1

   
1.2.0

   
1.3.0

   
1.4.1

   
1.5.0

   
1.6.0

   
1.6.1

   
1.7.0

   
1.7.1

   
1.7β

   
1.8.0

   
1.8.1

   
1.8.2

   
1.8.3

   
1.8β

   
1.9.0

   
1.9.0-s3branch

   
1.9.0a1

   
1.9.0a2

   
1.9.0b1

   
1.9.1

   
1.9.2

   
1.9.2a1

   
LeastAuthority.com automation

   
blocker

   
cannot reproduce

   
cloud-branch

   
code

catch-all for anything that can be fixed by writing code but isn't classified better

  
code-dirnodes

anything involving tahoe directories

  
code-encoding

immutable-file encoding format/layout, cap format, encoding/decoding algorithms

  
code-frontend

general frontend things: new user-facing interfaces, FTP/SFTP servers, FUSE-like interfaces

  
code-frontend-cli

CLI tools

  
code-frontend-ftp-sftp

   
code-frontend-magic-folder

   
code-frontend-web

webapi interfaces, user-facing "WUI" interfaces

  
code-mutable

anything involving mutable files: encoding/decoding, share format

  
code-network

Introducer, locating storage servers, establishing/maintaining connections to them

  
code-nodeadmin

node startup/shutdown, tools to create nodes, logging tools, management/monitoring tools, manhole, disk-space-limiting tools

  
code-peerselection

server selection/sorting algorithm, rebalancing code, allocation policy, swarming-download

  
code-storage

storage-server implementation, share-storage directory layout, client-to-server share transfer protocol

  
contrib

problems with non-core things that live in the source:contrib/ directory

  
critical

   
defect

   
dev-infrastructure

things that help us build Tahoe: buildbot, automated speed/memory/code-coverage tests and results-displayers, IRC channels, mailing lists, this Trac instance

  
documentation

docs items. Also use 'docs' keyword on tickets in more specific components.

  
duplicate

   
enhancement

   
fixed

   
invalid

   
major

   
minor

   
n/a

   
normal

   
operational

things involved in running a tahoe grid, external tools to monitor/maintain a grid (like "nodeadmin" but larger-scale). Was also used for issues with the allmydata.com grid.

  
packaging

setup.py script, library dependencies, binary packages, licensing, installation instructions

  
somebody else's problem

   
supercritical

   
task

   
trivial

   
unknown

Uncategorized. All tickets default to this component until someone updates it.

  
was already fixed

   
website

things about the tahoe-lafs.org website (and sometimes this Trac instance, shared with 'dev-infrastructure')

  
wontfix

   
worksforme
No labels
0.2.0
0.3.0
0.4.0
0.5.0
0.5.1
0.6.0
0.6.1
0.7.0
0.8.0
0.9.0
1.0.0
1.1.0
1.10.0
1.10.1
1.10.2
1.10a2
1.11.0
1.12.0
1.12.1
1.13.0
1.14.0
1.15.0
1.15.1
1.2.0
1.3.0
1.4.1
1.5.0
1.6.0
1.6.1
1.7.0
1.7.1
1.7β
1.8.0
1.8.1
1.8.2
1.8.3
1.8β
1.9.0
1.9.0-s3branch
1.9.0a1
1.9.0a2
1.9.0b1
1.9.1
1.9.2
1.9.2a1
LeastAuthority.com automation
blocker
cannot reproduce
cloud-branch
code
code-dirnodes
code-encoding
code-frontend
code-frontend-cli
code-frontend-ftp-sftp
code-frontend-magic-folder
code-frontend-web
code-mutable
code-network
code-nodeadmin
code-peerselection
code-storage
contrib
critical
defect
dev-infrastructure
documentation
duplicate
enhancement
fixed
invalid
major
minor
n/a
normal
operational
packaging
somebody else's problem
supercritical
task
trivial
unknown
was already fixed
website
wontfix
worksforme
Milestone
Clear milestone
No items
No milestone
1.7.1
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: tahoe-lafs/trac-2024-07-25#1098
No description provided.
Delete branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?