tahoe-lafs/trac-2024-07-25
2
0
Issues 1.1k Wiki Activity

FTP frontend should avoid caching plaintext of uploads #1083

New issue
Closed
opened 2010-06-15 23:26:59 +00:00 by davidsarah · 10 comments
davidsarah commented 2010-06-15 23:26:59 +00:00
Owner
Copy link

The SFTP frontend was changed to avoid using a cleartext temporary file for the contents of files opened for writing (see [EncryptedTemporaryFile in sftpd.py]source:src/allmydata/frontends/sftpd.py?rev=4478#L294). A similar change should be made to the FTP frontend.

Perhaps EncryptedTemporaryFile should be moved to [fileutil.py]source:/src/allmydata/util/fileutil.py so that it can be used by both SFTP and FTP.

The SFTP frontend was changed to avoid using a cleartext temporary file for the contents of files opened for writing (see [EncryptedTemporaryFile in sftpd.py]source:src/allmydata/frontends/sftpd.py?rev=4478#L294). A similar change should be made to the FTP frontend. Perhaps `EncryptedTemporaryFile` should be moved to [fileutil.py]source:/src/allmydata/util/fileutil.py so that it can be used by both SFTP and FTP.
tahoe-lafs added the
code-frontend
major
defect
1.7β
 labels 2010-06-15 23:26:59 +00:00
tahoe-lafs added this to the 1.8.0 milestone 2010-06-15 23:26:59 +00:00
davidsarah commented 2010-06-15 23:28:54 +00:00
Author
Owner
Copy link

Note that EncryptedTemporaryFile is not tested directly, only via the SFTP tests. It probably should be tested directly.

Note that `EncryptedTemporaryFile` is not tested directly, only via the SFTP tests. It probably should be tested directly.
tahoe-lafs modified the milestone from 1.8.0 to 1.7.1 2010-06-21 01:53:19 +00:00
davidsarah commented 2010-07-11 21:55:06 +00:00
Author
Owner
Copy link

The FTP frontend unfortunately has no tests (#512). On the other hand, EncryptedTemporaryFile is indirectly tested by the SFTP tests.

The FTP frontend unfortunately has no tests (#512). On the other hand, `EncryptedTemporaryFile` is indirectly tested by the SFTP tests.
zooko commented 2010-07-14 07:09:13 +00:00
Author
Owner
Copy link

Perhaps this should be bumped from v1.7.1 to v1.8.0 simply due to it being a nice new feature instead of a bug fix, clean-up, unfinished-business, etc.?

Perhaps this should be bumped from v1.7.1 to v1.8.0 simply due to it being a nice new feature instead of a bug fix, clean-up, unfinished-business, etc.?
zooko commented 2010-07-14 07:10:44 +00:00
Author
Owner
Copy link

Oh, it is sort of a bug-fix (potential security problem), clean-up (unify SFTP and FTP backends), and unfinished-business (SFTP got this feature in 1.7.0). So disregard comment:119670. :-)

Oh, it *is* sort of a bug-fix (potential security problem), clean-up (unify SFTP and FTP backends), and unfinished-business (SFTP got this feature in 1.7.0). So disregard [comment:119670](/tahoe-lafs/trac-2024-07-25/issues/1083#issuecomment-119670). :-)
davidsarah commented 2010-07-15 06:36:35 +00:00
Author
Owner
Copy link

The current patch seems to have caused a regression in SFTP that results in the test_openFile_write test hanging (probably something simple, but I haven't had time to track it down). So I wouldn't object to this being bumped to 1.8. Whether we'll fit it into 1.7.1 depends on how much the schedule slips :-)

The current patch seems to have caused a regression in SFTP that results in the test_openFile_write test hanging (probably something simple, but I haven't had time to track it down). So I wouldn't object to this being bumped to 1.8. Whether we'll fit it into 1.7.1 depends on how much the schedule slips :-)
davidsarah commented 2010-07-15 20:14:52 +00:00
Author
Owner
Copy link

Replying to davidsarah:

The current patch seems to have caused a regression in SFTP that results in the test_openFile_write test hanging...

I was mistaken; this was caused by sftp-no-trunc-files-opened-with-append.dpatch, not by this patch.

Replying to [davidsarah](/tahoe-lafs/trac-2024-07-25/issues/1083#issuecomment-119672): > The current patch seems to have caused a regression in SFTP that results in the test_openFile_write test hanging... I was mistaken; this was caused by [sftp-no-trunc-files-opened-with-append.dpatch](http://tahoe-lafs.org/trac/tahoe-lafs/attachment/ticket/1106/sftp-no-trunc-files-opened-with-append.dpatch), not by this patch.
davidsarah commented 2010-07-17 06:02:25 +00:00
Author
Owner
Copy link

Attachment make-ftp-use-encrypted-temporary-file.dpatch (11005 bytes) added

Move EncryptedTemporaryFile from SFTP frontend to allmydata.util.fileutil, and make the FTP frontend also use it (fi xing #1083). Also, docstrings for non-obvious usage restrictions on methods of EncryptedTemporaryFile.

**Attachment** make-ftp-use-encrypted-temporary-file.dpatch (11005 bytes) added Move [EncryptedTemporaryFile](wiki/EncryptedTemporaryFile) from SFTP frontend to allmydata.util.fileutil, and make the FTP frontend also use it (fi xing #1083). Also, docstrings for non-obvious usage restrictions on methods of [EncryptedTemporaryFile](wiki/EncryptedTemporaryFile).
make-ftp-use-encrypted-temporary-file.dpatch
11 KiB
zooko commented 2010-07-18 02:17:01 +00:00
Author
Owner
Copy link

I just reviewed the patch. +1! Thanks, David-Sarah!

Oh, it needs a NEWS snippet. I'll add that myself.

Should we remove the "test-needed" flag?

I just reviewed the patch. +1! Thanks, David-Sarah! Oh, it needs a NEWS snippet. I'll add that myself. Should we remove the "test-needed" flag?
davidsarah commented 2010-07-18 02:38:13 +00:00
Author
Owner
Copy link

Replying to zooko:

Should we remove the "test-needed" flag?

That would be part of #512, so yes.

Replying to [zooko](/tahoe-lafs/trac-2024-07-25/issues/1083#issuecomment-119674): > Should we remove the "test-needed" flag? That would be part of #512, so yes.
zooko commented 2010-07-18 05:39:52 +00:00
Author
Owner
Copy link

committed in changeset:05022dca36780b3b. Thanks!

committed in changeset:05022dca36780b3b. Thanks!
tahoe-lafs added the
fixed
 label 2010-07-18 05:39:52 +00:00
zooko closed this issue 2010-07-18 05:39:52 +00:00
Sign in to join this conversation.
No Branch/Tag specified
Branches Tags
No results found.
No results found.
Labels
Clear labels   
0.2.0

   
0.3.0

   
0.4.0

   
0.5.0

   
0.5.1

   
0.6.0

   
0.6.1

   
0.7.0

   
0.8.0

   
0.9.0

   
1.0.0

   
1.1.0

   
1.10.0

   
1.10.1

   
1.10.2

   
1.10a2

   
1.11.0

   
1.12.0

   
1.12.1

   
1.13.0

   
1.14.0

   
1.15.0

   
1.15.1

   
1.2.0

   
1.3.0

   
1.4.1

   
1.5.0

   
1.6.0

   
1.6.1

   
1.7.0

   
1.7.1

   
1.7β

   
1.8.0

   
1.8.1

   
1.8.2

   
1.8.3

   
1.8β

   
1.9.0

   
1.9.0-s3branch

   
1.9.0a1

   
1.9.0a2

   
1.9.0b1

   
1.9.1

   
1.9.2

   
1.9.2a1

   
LeastAuthority.com automation

   
blocker

   
cannot reproduce

   
cloud-branch

   
code

catch-all for anything that can be fixed by writing code but isn't classified better

  
code-dirnodes

anything involving tahoe directories

  
code-encoding

immutable-file encoding format/layout, cap format, encoding/decoding algorithms

  
code-frontend

general frontend things: new user-facing interfaces, FTP/SFTP servers, FUSE-like interfaces

  
code-frontend-cli

CLI tools

  
code-frontend-ftp-sftp

   
code-frontend-magic-folder

   
code-frontend-web

webapi interfaces, user-facing "WUI" interfaces

  
code-mutable

anything involving mutable files: encoding/decoding, share format

  
code-network

Introducer, locating storage servers, establishing/maintaining connections to them

  
code-nodeadmin

node startup/shutdown, tools to create nodes, logging tools, management/monitoring tools, manhole, disk-space-limiting tools

  
code-peerselection

server selection/sorting algorithm, rebalancing code, allocation policy, swarming-download

  
code-storage

storage-server implementation, share-storage directory layout, client-to-server share transfer protocol

  
contrib

problems with non-core things that live in the source:contrib/ directory

  
critical

   
defect

   
dev-infrastructure

things that help us build Tahoe: buildbot, automated speed/memory/code-coverage tests and results-displayers, IRC channels, mailing lists, this Trac instance

  
documentation

docs items. Also use 'docs' keyword on tickets in more specific components.

  
duplicate

   
enhancement

   
fixed

   
invalid

   
major

   
minor

   
n/a

   
normal

   
operational

things involved in running a tahoe grid, external tools to monitor/maintain a grid (like "nodeadmin" but larger-scale). Was also used for issues with the allmydata.com grid.

  
packaging

setup.py script, library dependencies, binary packages, licensing, installation instructions

  
somebody else's problem

   
supercritical

   
task

   
trivial

   
unknown

Uncategorized. All tickets default to this component until someone updates it.

  
was already fixed

   
website

things about the tahoe-lafs.org website (and sometimes this Trac instance, shared with 'dev-infrastructure')

  
wontfix

   
worksforme
No labels
0.2.0
0.3.0
0.4.0
0.5.0
0.5.1
0.6.0
0.6.1
0.7.0
0.8.0
0.9.0
1.0.0
1.1.0
1.10.0
1.10.1
1.10.2
1.10a2
1.11.0
1.12.0
1.12.1
1.13.0
1.14.0
1.15.0
1.15.1
1.2.0
1.3.0
1.4.1
1.5.0
1.6.0
1.6.1
1.7.0
1.7.1
1.7β
1.8.0
1.8.1
1.8.2
1.8.3
1.8β
1.9.0
1.9.0-s3branch
1.9.0a1
1.9.0a2
1.9.0b1
1.9.1
1.9.2
1.9.2a1
LeastAuthority.com automation
blocker
cannot reproduce
cloud-branch
code
code-dirnodes
code-encoding
code-frontend
code-frontend-cli
code-frontend-ftp-sftp
code-frontend-magic-folder
code-frontend-web
code-mutable
code-network
code-nodeadmin
code-peerselection
code-storage
contrib
critical
defect
dev-infrastructure
documentation
duplicate
enhancement
fixed
invalid
major
minor
n/a
normal
operational
packaging
somebody else's problem
supercritical
task
trivial
unknown
was already fixed
website
wontfix
worksforme
Milestone
Clear milestone
No items
No milestone
1.7.1
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: tahoe-lafs/trac-2024-07-25#1083
No description provided.
Delete branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?