From d4366c18edcb858c3bbdc60bcde4a2bf8973dc9e Mon Sep 17 00:00:00 2001 From: zooko <> Date: Sat, 17 Dec 2011 01:38:50 +0000 Subject: [PATCH] update links and formatting [Imported from Trac: page PatchReviewProcess, version 18] --- PatchReviewProcess.md | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/PatchReviewProcess.md b/PatchReviewProcess.md index c37b49e..ed1ce9f 100644 --- a/PatchReviewProcess.md +++ b/PatchReviewProcess.md @@ -19,15 +19,15 @@ more specialized knowledge to review, but most don't. Here is the overall process for patch review. For technical tips, see below. - 1. Go to . Click on "[View Tickets](http://tahoe-lafs.org/trac/tahoe/wiki/ViewTickets)". Click on "[review-needed]query:keywords~=review-needed&status=!closed&group=milestone". + 1. Go to . Click on "[View Tickets](ViewTickets)". Click on "[review-needed]query:keywords~=review-needed&status=!closed&group=milestone". 2. You can read everything without registering, but to add comments or change tickets you have to be logged in. Registering is easy -- click the "Register" link at the top right of the page. 3. Read tickets until you find one that you can review. 4. (optional) Expand "modify ticket" and click "accept", then submit changes. This marks you as the person reviewing this patch. If you don't want to commit to this then you can skip this step. 5. Read the patch until you understand the docs, tests, code and comments in it. You can use the "Browse source" button at the top of the page to read the current versions of the files that the patch changes. 1. If you can't understand the patch after spending some time on it, then say so in a comment on the ticket! This might mean that we need to add documentation or comments or to refactor the code. On the other hand, it might just be that you don't have enough context to understand the code. That's okay too, so go ahead and speak up. 2. Check whether every feature or bugfix in the patch has an accompanying test in the patch. - 3. If you find errors or omissions in the docs, tests, code or comments then write that down in the ticket, remove the "review-needed" keyword from the keywords, and assign the ticket to someone other than yourself. (Assign it to the original author of the patch, or someone who seems likely to fix the patch, or "nobody".) - 4. If you understand the patch and find no errors or omissions then write a comment on the ticket saying that you reviewed it, remove the keyword "review-needed", add the keyword "reviewed" and assign it to someone with repository write access (currently 'zooko', 'warner' and 'davidsarah'). We'll commit it to trunk. + 3. If you find errors or omissions in the docs, tests, code or comments then write that down in the ticket, remove the `review-needed` keyword from the keywords, and assign the ticket to someone other than yourself. (Assign it to the original author of the patch, or someone who seems likely to fix the patch, or "nobody".) + 4. If you understand the patch and find no errors or omissions then write a comment on the ticket saying that you reviewed it, remove the keyword `review-needed`, add the keyword `reviewed` and assign it to someone with repository write access (currently 'zooko', 'warner', 'davidsarah', and 'kevan'). We'll commit it to trunk. 5. Feel good about yourself. Thank you for helping with our little project attempting to improve the world! # Advanced @@ -48,13 +48,13 @@ Attachments in a ticket have two links, a name, which points to an html page wit For the #1149 ticket, for example, there are two links for the attachment named "test-for-webopen.darcs.patch": - * The link with a name points here: - * The link with a download icon, here: + * The link with a name points here: + * The link with a download icon, here: The latter can be used to apply a patch, like this example shows: ``` -$ wget 'http://tahoe-lafs.org/trac/tahoe-lafs/raw-attachment/ticket/1149/test-for-webopen.darcs.patch' +$ wget 'https://tahoe-lafs.org/trac/tahoe-lafs/raw-attachment/ticket/1149/test-for-webopen.darcs.patch' --2011-07-31 20:23:39-- http://tahoe-lafs.org/trac/tahoe-lafs/raw-attachment/ticket/1149/test-for-webopen.darcs.patch Connecting to 127.0.0.1:8123... connected. Proxy request sent, awaiting response... 200 Ok