tahoe-lafs/trac-2024-07-25
2
0
Issues 1.1k Wiki Activity

Add a section spelling out how to apply patches from tickets. 

[Imported from Trac: page PatchReviewProcess, version 16]
nejucomo 2011-08-01 03:26:06 +00:00
parent ef737ae515
commit ba688e9627
1 changed files with 34 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

33
PatchReviewProcess.md

@ -17,6 +17,8 @@ more specialized knowledge to review, but most don't.
# How to review patches
Here is the overall process for patch review. For technical tips, see below.
1. Go to <http://tahoe-lafs.org> . Click on "[View Tickets](http://tahoe-lafs.org/trac/tahoe/wiki/ViewTickets)". Click on "[review-needed]query:keywords~=review-needed&status=!closed&group=milestone".
2. You can read everything without registering, but to add comments or change tickets you have to be logged in. Registering is easy -- click the "Register" link at the top right of the page.
3. Read tickets until you find one that you can review.
@ -39,3 +41,34 @@ Once you decide that you like reviewing tickets and you get into the habit of do
Two simple suggestions:
1. Say something nice about the author or their code.
2. You don't have to be extra picky.
# Technical Tips
Please suggest improvements here if you run into technical snags while reviewing a ticket.
## Ticket attachment links
Attachments in a ticket have two links, a name, which points to an html page with prettification, and a raw download link. You can save the download link (such as by `wget`) and use `darcs apply` to configure your repository to test a particular patch.
For the #1149 ticket, for example, there are two links for the attachment named "test-for-webopen.darcs.patch":
* The link with a name points here: <http://tahoe-lafs.org/trac/tahoe-lafs/attachment/ticket/1149/test-for-webopen.darcs.patch>
* The link with a download icon, here: <http://tahoe-lafs.org/trac/tahoe-lafs/raw-attachment/ticket/1149/test-for-webopen.darcs.patch>
The latter can be used to apply a patch, like this example shows:
```
$ wget 'http://tahoe-lafs.org/trac/tahoe-lafs/raw-attachment/ticket/1149/test-for-webopen.darcs.patch'
--2011-07-31 20:23:39-- http://tahoe-lafs.org/trac/tahoe-lafs/raw-attachment/ticket/1149/test-for-webopen.darcs.patch
Connecting to 127.0.0.1:8123... connected.
Proxy request sent, awaiting response... 200 Ok
Length: 18275 (18K) [text/x-diff]
Saving to: “test-for-webopen.darcs.patch”
100%[==============================>] 18,275 21.8K/s in 0.8s
2011-07-31 20:23:54 (21.8 KB/s) - “test-for-webopen.darcs.patch” saved [18275/18275]
$ darcs apply test-for-webopen.darcs.patch
Finished applying...
```