tahoe-lafs/trac-2024-07-25
2
0
Issues 1.1k Wiki Activity

Update fourth step again, this time to delete all instances of from builtins import name 

[Imported from Trac: page Python3, version 75]
jaraco 2021-02-15 18:19:21 +00:00
parent 95985716d2
commit 9cc0398864
1 changed files with 3 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
Python3.md

@ -119,10 +119,12 @@ if PY2:
This adds builtins that match Python 3's semantics. The `#noqa: F401` keeps flake8/pyflakes from complaining about unused imports. We do unused imports so that people changing code later don't have to manually check if `map()` is old style or new style. This adds builtins that match Python 3's semantics. The `#noqa: F401` keeps flake8/pyflakes from complaining about unused imports. We do unused imports so that people changing code later don't have to manually check if `map()` is old style or new style.
Then, delete any instances of `from builtins import <name>`.
Consider using this sed command to execute the above: Consider using this sed command to execute the above:
``` ```
$ sed -ie '/from future import standard_library/d;/standard_library.install_aliases()/d;/from builtins import str/d;s/from builtins import \*/from future.utils import PY2\\nif PY2:\\n from future.builtins import filter, map, zip, ascii, chr, hex, input, next, oct, open, pow, round, super, bytes, dict, list, object, range, str, max, min # noqa: F401/' src/allmydata/test/test_runner.py $ sed -ie '/from future import standard_library/d;/standard_library.install_aliases()/d;s/from builtins import \*/from future.utils import PY2\\nif PY2:\\n from future.builtins import filter, map, zip, ascii, chr, hex, input, next, oct, open, pow, round, super, bytes, dict, list, object, range, str, max, min # noqa: F401/;/from builtins import .*/d' path/to/file.py
``` ```
**Fourth**, manually review the code. Futureize is nice, but it very definitely doesn't catch everything, or it makes wrong decisions. **Fourth**, manually review the code. Futureize is nice, but it very definitely doesn't catch everything, or it makes wrong decisions.