tahoe-lafs/trac-2024-07-25
2
0
Issues 1.1k Wiki Activity

assign to someone with repository write access 

[Imported from Trac: page PatchReviewProcess, version 5]
davidsarah 2010-02-16 02:57:46 +00:00
parent d223a586b7
commit 7a5bbb32ad
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
PatchReviewProcess.md

@ -23,5 +23,5 @@ more specialized knowledge to review, but most don't.
5. Read the patch until you understand all of the docs, tests, code and comments in it. You can use the "Browse source" button at the top of the page to read the current versions of the files that the patch changes. 5. Read the patch until you understand all of the docs, tests, code and comments in it. You can use the "Browse source" button at the top of the page to read the current versions of the files that the patch changes.
1. If you can't understand the patch after spending some time on it, then say so in a comment on the ticket! This might be taken as a reason to add documentation or comments or to refactor the code. On the other hand, it might just be that you don't have enough context to understand the code. That's okay too. 1. If you can't understand the patch after spending some time on it, then say so in a comment on the ticket! This might be taken as a reason to add documentation or comments or to refactor the code. On the other hand, it might just be that you don't have enough context to understand the code. That's okay too.
2. If you find errors or omissions in the docs, tests, code or comments then write that down in the ticket, remove the "review" keyword from the keywords, and assign the ticket to someone other than yourself. (That would be the original author of the patch, or someone who seems likely to fix the patch, or if you can't think of anyone better then assign it to me.) 2. If you find errors or omissions in the docs, tests, code or comments then write that down in the ticket, remove the "review" keyword from the keywords, and assign the ticket to someone other than yourself. (That would be the original author of the patch, or someone who seems likely to fix the patch, or if you can't think of anyone better then assign it to me.)
3. If you understand the patch and find no errors or omissions then remove the keyword "review", add the keyword "reviewed" and assign it to me. I'll commit it to trunk. 3. If you understand the patch and find no errors or omissions then remove the keyword "review", add the keyword "reviewed" and assign it to someone with repository write access (currently 'zooko', 'warner' and 'davidsarah'). We'll commit it to trunk.
4. Feel good about yourself. Thank you for helping with our little project attempting to improve the world! 4. Feel good about yourself. Thank you for helping with our little project attempting to improve the world!