From 6a3f0d4a8a45adb8638a734a1e5b53a4632187c4 Mon Sep 17 00:00:00 2001 From: rpatterson <> Date: Fri, 18 Sep 2020 18:02:22 +0000 Subject: [PATCH] Correct Trac terminolody [Imported from Trac: page Patches, version 36] --- Patches.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Patches.md b/Patches.md index ba866bf..fce30b3 100644 --- a/Patches.md +++ b/Patches.md @@ -19,7 +19,7 @@ Once you think you have solved the issue run the test suite with `tox`. This ens Now that all of the existing unit tests pass, [write your own tests](https://tahoe-lafs.org/trac/tahoe-lafs/wiki/HowToWriteTests) for the ticket if they don't already exist, and make sure that they pass. Also ensure that `tox -e codechecks` finds no errors or warnings. -Finally, push your branch to Github and [open a pull request](https://help.github.com/articles/creating-a-pull-request). Please add the tag `review-needed` to the ticket and add a link to the pull request. If you had trouble writing unit tests for your patch, don't worry. Submit the pull request anyway and add the tag `test-needed` to the ticket. +Finally, push your branch to Github and [open a pull request](https://help.github.com/articles/creating-a-pull-request). Please add the keyword `review-needed` to the ticket and add a link to the pull request. If you had trouble writing unit tests for your patch, don't worry. Submit the pull request anyway and add the keyword `test-needed` to the ticket. # Design reviews