tahoe-lafs/trac-2024-07-25
2
0
Issues 1.1k Wiki Activity

write a note saying that you reviewed it 

[Imported from Trac: page PatchReviewProcess, version 9]
zooko 2010-05-19 17:36:39 +00:00
parent c48d95b506
commit 4c8786ad79
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
PatchReviewProcess.md

@ -23,7 +23,7 @@ more specialized knowledge to review, but most don't.
5. Read the patch until you understand the docs, tests, code and comments in it. You can use the "Browse source" button at the top of the page to read the current versions of the files that the patch changes.
1. If you can't understand the patch after spending some time on it, then say so in a comment on the ticket! This might be taken as a reason to add documentation or comments or to refactor the code. On the other hand, it might just be that you don't have enough context to understand the code. That's okay too.
2. If you find errors or omissions in the docs, tests, code or comments then write that down in the ticket, remove the "review-needed" keyword from the keywords, and assign the ticket to someone other than yourself. (Assign it to the original author of the patch, or someone who seems likely to fix the patch, or if you can't think of anyone better then assign it to Zooko.)
3. If you understand the patch and find no errors or omissions then remove the keyword "review-needed", add the keyword "reviewed" and assign it to someone with repository write access (currently 'zooko', 'warner' and 'davidsarah'). We'll commit it to trunk.
3. If you understand the patch and find no errors or omissions then write a comment on the ticket saying that you reviewed it, remove the keyword "review-needed", add the keyword "reviewed" and assign it to someone with repository write access (currently 'zooko', 'warner' and 'davidsarah'). We'll commit it to trunk.
4. Feel good about yourself. Thank you for helping with our little project attempting to improve the world!
# Advanced