From 30031cfd440f300440c517ef5138cb9726e81820 Mon Sep 17 00:00:00 2001 From: daira <> Date: Thu, 8 Aug 2013 12:58:14 +0000 Subject: [PATCH] Another typo [Imported from Trac: page PatchReviewProcess, version 25] --- PatchReviewProcess.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/PatchReviewProcess.md b/PatchReviewProcess.md index ad0557a..85c99dc 100644 --- a/PatchReviewProcess.md +++ b/PatchReviewProcess.md @@ -44,4 +44,4 @@ A few simple suggestions: The patch you're reviewing might be given either as an attachment, or as a github pull request. If it's the latter, then it's encouraged to use line comments on github for detailed comments or questions on the code. However, you should also write a short summary of the review on the trac ticket. (Sometimes this can be as simple as "+1" if there are no further issues to discuss.) -In all cases it's recommended to apply the patch or check out the code and run the full test suite locally (using `python setup.py test` since a rebuild is usually necessary), to check that it passes. You'd be surprised how often a patch author thinks it passes tests, but a "harmless" last-minute change, a portability problem, or a nondeterministic race condition causes it to fail when checked. (There's usually no need to test on multiple platforms at this stage though -- that's whatthe buildbots are for.) All committed code should also be free of pyflakes errors or warnings. +In all cases it's recommended to apply the patch or check out the code and run the full test suite locally (using `python setup.py test` since a rebuild is usually necessary), to check that it passes. You'd be surprised how often a patch author thinks it passes tests, but a "harmless" last-minute change, a portability problem, or a nondeterministic race condition causes it to fail when checked. (There's usually no need to test on multiple platforms at this stage though -- that's what the buildbots are for.) All committed code should also be free of pyflakes errors or warnings.