From 004827d4e66570e7be6b9cfdfa92410a66b42fc9 Mon Sep 17 00:00:00 2001
From: davidsarah <>
Date: Sun, 9 Jan 2011 02:01:33 +0000
Subject: [PATCH] design reviews

[Imported from Trac: page PatchReviewProcess, version 13]
---
 PatchReviewProcess.md | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/PatchReviewProcess.md b/PatchReviewProcess.md
index 48eb39c..52f81b2 100644
--- a/PatchReviewProcess.md
+++ b/PatchReviewProcess.md
@@ -27,6 +27,10 @@ more specialized knowledge to review, but most don't.
   4. If you understand the patch and find no errors or omissions then write a comment on the ticket saying that you reviewed it, remove the keyword "review-needed", add the keyword "reviewed" and assign it to someone with repository write access (currently 'zooko', 'warner' and 'davidsarah'). We'll commit it to trunk.
   5. Feel good about yourself.  Thank you for helping with our little project attempting to improve the world!
 
+# Design reviews
+
+To request a design review, explain your design (with or without a patch) and then add the [design-review-needed]query:keywords~=design-review-needed&status=!closed&group=milestone tag. Completion of a design review will normally not directly result in a patch being committed. The main goal of a design review is to give the person working on the ticket confidence that there are no show-stopping issues with the approach they are taking, and to get feedback on smaller issues that are useful to take into account before doing further work on a patch.
+
 # Advanced
 
 Once you decide that you like reviewing tickets and you get into the habit of doing it frequently, then read this essay by Jonathan Lange on how to do it well: [Your Code Sucks and I Hate You: The Social Dynamics of Code Reviews](http://mumak.net/stuff/your-code-sucks.html).
\ No newline at end of file