CLI commands should follow HTTP redirects #965

Open
opened 2010-02-21 02:23:18 +00:00 by davidsarah · 0 comments
davidsarah commented 2010-02-21 02:23:18 +00:00
Owner

As mentioned in #958, it is normally the responsibility of an HTTP client to follow redirects, but the CLI commands don't do so. This is because source:src/allmydata/scripts/common_http.py uses Python's httplib directly. Up to now this hasn't mattered because the CLI commands only make HTTP requests that will not redirect. However, if #958 is implemented then any request might redirect.

This is easy to fix, for example by using urllib2 as described here.

As mentioned in #958, it is normally the responsibility of an HTTP client to follow redirects, but the CLI commands don't do so. This is because source:src/allmydata/scripts/common_http.py uses Python's `httplib` directly. Up to now this hasn't mattered because the CLI commands only make HTTP requests that will not redirect. However, if #958 is implemented then any request might redirect. This is easy to fix, for example by using `urllib2` as described [here](http://www.diveintopython.net/http_web_services/redirects.html).
tahoe-lafs added the
code-frontend-cli
major
defect
1.6.0
labels 2010-02-21 02:23:18 +00:00
tahoe-lafs added this to the 1.7.0 milestone 2010-02-21 02:23:18 +00:00
tahoe-lafs modified the milestone from 1.7.0 to soon 2010-06-19 01:04:23 +00:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: tahoe-lafs/trac-2024-07-25#965
No description provided.