show ?-IMM and ?-RO for immutable and read-only unknown nodes in directory listings #931

Closed
opened 2010-01-28 22:30:20 +00:00 by davidsarah · 3 comments
davidsarah commented 2010-01-28 22:30:20 +00:00
Owner

In describing the fix for #833, Zooko said:

#833 also adds some very nice forward-compatibility features, so that when future versions of Tahoe-LAFS start uploading new kinds of capabilities, people using Tahoe-LAFS v1.6 will get a reasonable
indicator showing that there is something here that is immutable, but is from the future so you can't actually see it, instead of getting a traceback or some sort of behavior that violates the deep-
immutability property.

However, #833 didn't actually change directory listings to show unknown caps as immutable (?-IMM) or read-only (?-RO). I have a patch to do that.

In describing the fix for #833, Zooko said: > #833 also adds some very nice forward-compatibility features, so that when future versions of Tahoe-LAFS start uploading new kinds of capabilities, people using Tahoe-LAFS v1.6 will get a reasonable indicator showing that there is something here that is immutable, but is from the future so you can't actually see it, instead of getting a traceback or some sort of behavior that violates the deep- immutability property. However, #833 didn't actually change directory listings to show unknown caps as immutable (?-IMM) or read-only (?-RO). I have a patch to do that.
tahoe-lafs added the
code-frontend-web
major
enhancement
1.5.0
labels 2010-01-28 22:30:20 +00:00
tahoe-lafs added this to the 1.6.0 milestone 2010-01-28 22:30:20 +00:00
davidsarah commented 2010-01-28 22:31:14 +00:00
Author
Owner

Attachment show-unknown-imm-and-ro-darcspatch.txt (46330 bytes) added

Show -IMM and -RO suffixes for types of immutable and read-only unknown nodes in directory listings (with tests)

**Attachment** show-unknown-imm-and-ro-darcspatch.txt (46330 bytes) added Show -IMM and -RO suffixes for types of immutable and read-only unknown nodes in directory listings (with tests)
zooko commented 2010-01-29 03:23:38 +00:00
Author
Owner

The ternary operator isn't available in Python 2.4 so we can't use it yet:

+        d.addCallback(_check_directory_html, "-IMM" if immutable else "-RO")
The ternary operator isn't available in Python 2.4 so we can't use it yet: ``` + d.addCallback(_check_directory_html, "-IMM" if immutable else "-RO") ```
zooko commented 2010-01-29 13:17:58 +00:00
Author
Owner

fixed by changeset:4560e021a9f9d311. Thank you!

fixed by changeset:4560e021a9f9d311. Thank you!
tahoe-lafs added the
fixed
label 2010-01-29 13:17:58 +00:00
zooko closed this issue 2010-01-29 13:17:58 +00:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: tahoe-lafs/trac-2024-07-25#931
No description provided.