tahoe-lafs/trac-2024-07-25

"other representations" broken in webish ui #458

New issue

Closed

opened 2008-06-11 00:56:44 +00:00 by robk · 2 comments

robk commented

2008-06-11 00:56:44 +00:00

Owner

when viewing a directory in the webish ui, the 'other respresentations' links for files are broken, they all point to "/uri/filename.ext?..."

thus providing representations such as

"'filename.ext' is not a valid file- or directory- cap"

when viewing a directory in the webish ui, the 'other respresentations' links for files are broken, they all point to "/uri/filename.ext?..." thus providing representations such as "'filename.ext' is not a valid file- or directory- cap"

tahoe-lafs added the

code-frontend-web

labels 2008-06-11 00:56:44 +00:00

zooko commented

2008-06-11 15:54:36 +00:00

Author

Owner

Fixed by changeset:65618ba5a26c5699, I think. But also we really want to make it so that directories without trailing slashes get 301-moved-permanently-ed to the same thing with a trailing slash, which Brian says he knows how to easily enable.

Fixed by changeset:65618ba5a26c5699, I think. But also we really want to make it so that directories without trailing slashes get 301-moved-permanently-ed to the same thing with a trailing slash, which Brian says he knows how to easily enable.

tahoe-lafs added this to the 1.1.0 milestone 2008-06-11 15:54:36 +00:00

warner commented

2008-06-11 22:08:34 +00:00

Author

Owner

We fixed this for 1.1.0, by making the subdirectory links point to a URL that ends in a slash.

Then we added the proper addSlash=True, so that if you happen to follow a link that doesn't end in a slash, you get redirected to a page that ends in a slash. We also had to fix a unit test that incorrectly asserted that a mutable-file overwrite when-done URL did not end in a slash. This second fix went in after the 1.1.0 tag, so it will be first released in 1.1.1 .

So this is the first ticket closed with a 1.1.1 milestone.

We fixed this for 1.1.0, by making the subdirectory links point to a URL that ends in a slash. Then we added the proper addSlash=True, so that if you happen to follow a link that doesn't end in a slash, you get redirected to a page that ends in a slash. We also had to fix a unit test that incorrectly asserted that a mutable-file overwrite when-done URL did not end in a slash. This second fix went in after the 1.1.0 tag, so it will be first released in 1.1.1 . So this is the first ticket closed with a 1.1.1 milestone.

tahoe-lafs added the

label 2008-06-11 22:08:34 +00:00

warner closed this issue

2008-06-11 22:08:34 +00:00

Sign in to join this conversation.

No labels

LeastAuthority.com automation

cannot reproduce

code-frontend-cli

code-frontend-ftp-sftp

code-frontend-magic-folder

code-frontend-web

code-peerselection

dev-infrastructure

somebody else's problem

was already fixed

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: tahoe-lafs/trac-2024-07-25#458

No description provided.