The list of NURLs in announcements should be a set #4046

Closed
opened 2023-07-11 22:03:58 +00:00 by itamarst · 1 comment
itamarst commented 2023-07-11 22:03:58 +00:00
Owner

In storage_client.py there is logic to decide if an announcement is worth paying attention to, by comparing it to the old known announcement. NURLs might end up in a different order, but that is not a semantic difference. So this suggests NURLs should be sent as a set.

In `storage_client.py` there is logic to decide if an announcement is worth paying attention to, by comparing it to the old known announcement. NURLs might end up in a different order, but that is not a semantic difference. So this suggests NURLs should be sent as a set.
tahoe-lafs added the
unknown
normal
defect
n/a
labels 2023-07-11 22:03:58 +00:00
tahoe-lafs added this to the HTTP Storage Protocol milestone 2023-07-11 22:03:58 +00:00
GitHub <noreply@github.com> commented 2023-07-20 15:46:00 +00:00
Author
Owner

In f7f30c78/trunk:

Merge pull request #1315 from tahoe-lafs/4046.nurls-are-set

Make NURLs a set

Fixes ticket:4046
In [f7f30c78/trunk](/tahoe-lafs/trac-2024-07-25/commit/f7f30c78b727c6d4e799e5bb2634d3cfdf9af2a4): ``` Merge pull request #1315 from tahoe-lafs/4046.nurls-are-set Make NURLs a set Fixes ticket:4046 ```
tahoe-lafs added the
fixed
label 2023-07-20 15:46:00 +00:00
GitHub <noreply@github.com> closed this issue 2023-07-20 15:46:00 +00:00
Sign in to join this conversation.
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: tahoe-lafs/trac-2024-07-25#4046
No description provided.