tahoe-lafs/trac-2024-07-25

Logging issues in foolscap on Python 3 #3708

New issue

Closed

opened 2021-05-10 14:43:34 +00:00 by itamarst · 2 comments

itamarst commented

2021-05-10 14:43:34 +00:00

Owner

When running integration tests:


}}2021-05-10T10:40:57-0400 [stdout#info] GATHERER: unable to serialize {'facility': 'tahoe.storage_broker', 'format': '%(name)s provided version info %(version)s', 'incarnation': ('86433dff70db2783', None), 'level': 10, 'name': b'q26hhekw', 'num': 626, 'parent': 617, 'time': 1620657650.2063904, 'umid': 'SWmJYg', 'version': {b'application-version': b'tahoe-lafs/1.14.0.post3323', b'http://allmydata.org/tahoe/protocols/storage/v1': {b'available-space': 7235896832, b'delete-mutable-shares-with-zero-length-writev': True, b'fills-holes-with-zero-bytes': True, b'maximum-immutable-share-size': 7235896832, b'maximum-mutable-share-size': 69105000000000000, b'prevents-read-past-end-of-share-data': True, b'tolerates-immutable-read-overrun': True```: keys must be a string}

When running integration tests: ``` }}2021-05-10T10:40:57-0400 [stdout#info] GATHERER: unable to serialize {'facility': 'tahoe.storage_broker', 'format': '%(name)s provided version info %(version)s', 'incarnation': ('86433dff70db2783', None), 'level': 10, 'name': b'q26hhekw', 'num': 626, 'parent': 617, 'time': 1620657650.2063904, 'umid': 'SWmJYg', 'version': {b'application-version': b'tahoe-lafs/1.14.0.post3323', b'http://allmydata.org/tahoe/protocols/storage/v1': {b'available-space': 7235896832, b'delete-mutable-shares-with-zero-length-writev': True, b'fills-holes-with-zero-bytes': True, b'maximum-immutable-share-size': 7235896832, b'maximum-mutable-share-size': 69105000000000000, b'prevents-read-past-end-of-share-data': True, b'tolerates-immutable-read-overrun': True```: keys must be a string}

tahoe-lafs added the

labels 2021-05-10 14:43:34 +00:00

tahoe-lafs added this to the Support Python 3 milestone 2021-05-10 14:43:34 +00:00

itamarst commented

2021-07-05 22:40:22 +00:00

Author

Owner

The underlying bug is in Foolscap, I've opened an issue: https://github.com/warner/foolscap/issues/88

Probably we can ensure we don't pass bytes to Foolscap logging, though, so will see if that's possible.

The underlying bug is in Foolscap, I've opened an issue: <https://github.com/warner/foolscap/issues/88> Probably we can ensure we don't pass bytes to Foolscap logging, though, so will see if that's possible.

GitHub <noreply@github.com> commented

2021-07-09 21:27:51 +00:00

Author

Owner

In 8e28a9d/trunk:

Merge pull request #1094 from tahoe-lafs/3708.bytes-logging

Remove bytes from Foolscap logging

Fixes ticket:3708

In [8e28a9d/trunk](/tahoe-lafs/trac-2024-07-25/commit/8e28a9d0e02fde2388aca549da2b5c452ac4337f): ``` Merge pull request #1094 from tahoe-lafs/3708.bytes-logging Remove bytes from Foolscap logging Fixes ticket:3708 ```

tahoe-lafs added the

fixed

label 2021-07-09 21:27:51 +00:00

GitHub <noreply@github.com> closed this issue

2021-07-09 21:27:51 +00:00