web ui does not display size of files in vdrive #37

Closed
opened 2007-05-04 19:04:27 +00:00 by faried · 9 comments
faried commented 2007-05-04 19:04:27 +00:00
Owner

The client web interface lists file types (name, type, id, etc), but not the file size.

The client web interface lists file types (name, type, id, etc), but not the file size.
tahoe-lafs added the
code
trivial
enhancement
labels 2007-05-04 19:04:27 +00:00
faried commented 2007-05-04 20:21:24 +00:00
Author
Owner

Fixed it for now. Tried to attach my patch, but got a perm denied error for /home/trac/projects/tahoe/attachments/ticket, so did a darcs --send zooko.

Fixed it for now. Tried to attach my patch, but got a perm denied error for /home/trac/projects/tahoe/attachments/ticket, so did a darcs --send zooko.
tahoe-lafs added the
fixed
label 2007-05-04 20:21:24 +00:00
faried closed this issue 2007-05-04 20:21:24 +00:00
zooko commented 2007-05-04 22:17:48 +00:00
Author
Owner

Attachment 8309.1.txt (99 bytes) added

Faried's note that came with his patch in e-mail.

**Attachment** 8309.1.txt (99 bytes) added Faried's note that came with his patch in e-mail.
zooko commented 2007-05-04 22:18:09 +00:00
Author
Owner

Attachment 8309.2.txt (1912 bytes) added

Faried's patch

**Attachment** 8309.2.txt (1912 bytes) added Faried's patch
1.9 KiB
zooko commented 2007-05-04 22:18:18 +00:00
Author
Owner

Attempting to attach Faried's patch in order to test trac's permissions for storing attachments.

Attempting to attach Faried's patch in order to test trac's permissions for storing attachments.
tahoe-lafs removed the
fixed
label 2007-05-04 22:18:18 +00:00
zooko reopened this issue 2007-05-04 22:18:18 +00:00
zooko commented 2007-05-07 02:44:49 +00:00
Author
Owner

fixed by changeset:24d4e072ddbb94da

fixed by changeset:24d4e072ddbb94da
tahoe-lafs added the
fixed
label 2007-05-07 02:44:49 +00:00
zooko closed this issue 2007-05-07 02:44:49 +00:00
warner commented 2007-05-07 18:16:39 +00:00
Author
Owner

unit tests!

unit tests!
zooko commented 2007-05-16 15:45:42 +00:00
Author
Owner

(http://allmydata.org/tahoe-figleaf/figleaf-edgy-186/allmydata.webish.html)

Hm. All the code added by changeset:24d4e072ddbb94da is already covered by the existing unit tests. How could we test it further?

(http://allmydata.org/tahoe-figleaf/figleaf-edgy-186/allmydata.webish.html) Hm. All the code added by changeset:24d4e072ddbb94da is already covered by the existing unit tests. How could we test it further?
tahoe-lafs removed the
fixed
label 2007-05-16 15:45:42 +00:00
zooko reopened this issue 2007-05-16 15:45:42 +00:00
warner commented 2007-05-24 00:23:28 +00:00
Author
Owner

test_system.SystemTest._test_web._got_subdir1 should use a regexp to assert that the correct size of the file is present in the HTML page that lists the directory.

I'll take a look at it. I just wanted to encourage us all to think about always adding unit tests along with bugfixes or enhancements. The fact that the code in question is being executed at all during the unit tests is a good sign, but knowing that we have a test which is specifically designed to make sure the code is actually working as intended is much much better.

Having that test pass is an added bonus :).

test_system.SystemTest._test_web._got_subdir1 should use a regexp to assert that the correct size of the file is present in the HTML page that lists the directory. I'll take a look at it. I just wanted to encourage us all to think about always adding unit tests along with bugfixes or enhancements. The fact that the code in question is being executed at all during the unit tests is a good sign, but knowing that we have a test which is specifically designed to make sure the code is actually working as intended is much much better. Having that test *pass* is an added bonus :).
warner commented 2007-05-24 00:28:31 +00:00
Author
Owner

done, in changeset:83daa265ba4907bd. Closing for good this time.

done, in changeset:83daa265ba4907bd. Closing for good this time.
tahoe-lafs added the
fixed
0.2.0
labels 2007-05-24 00:28:31 +00:00
warner closed this issue 2007-05-24 00:28:31 +00:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: tahoe-lafs/trac-2024-07-25#37
No description provided.