make sure log-gathering for clients is controllable by overwriting the log_gatherer.furl #363

Closed
opened 2008-03-21 23:03:58 +00:00 by zooko · 2 comments
zooko commented 2008-03-21 23:03:58 +00:00
Owner

Make sure that an empty log_gatherer.furl won't cause a client to fail on startup.

The conf wizard backend for allmydata.com can add or overwrite configuration files in the client's basedir, but it can't delete them, so if it needs to turn off a client's log_gatherer.furl, it will have to do it by overwriting it with the empty file.

Make sure that an empty log_gatherer.furl won't cause a client to fail on startup. The conf wizard backend for allmydata.com can add or overwrite configuration files in the client's basedir, but it can't delete them, so if it needs to turn off a client's log_gatherer.furl, it will have to do it by overwriting it with the empty file.
tahoe-lafs added the
code-nodeadmin
major
enhancement
0.9.0
labels 2008-03-21 23:03:58 +00:00
tahoe-lafs added this to the 1.0.0 milestone 2008-03-21 23:03:58 +00:00
warner commented 2008-03-25 19:01:44 +00:00
Author
Owner

According to the code, an empty furlfile will be treated exactly as if it didn't exist.

Manual testing confirms this. Note that the file must be of zero length to be ignored. If the file contains a single newline (anything that doesn't evaluate as False) will cause an exception, probably fatal.

According to the code, an empty furlfile will be treated exactly as if it didn't exist. Manual testing confirms this. Note that the file must be of zero length to be ignored. If the file contains a single newline (anything that doesn't evaluate as False) will cause an exception, probably fatal.
tahoe-lafs added the
fixed
label 2008-03-25 19:01:44 +00:00
warner closed this issue 2008-03-25 19:01:44 +00:00
warner commented 2008-03-25 19:53:44 +00:00
Author
Owner

Oh, actually, we do a strip() of the contents. So a file that contains only whitespace will be treated as if it didn't exist.

Oh, actually, we do a strip() of the contents. So a file that contains only whitespace will be treated as if it didn't exist.
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: tahoe-lafs/trac-2024-07-25#363
No description provided.