tahoe-lafs/trac-2024-07-25
2
0
Issues 1.1k Wiki Activity

tahoe backup crashes when an upload operation fails #2918

New issue
Open
opened 2018-04-10 15:41:09 +00:00 by exarkun · 0 comments
exarkun commented 2018-04-10 15:41:09 +00:00
Owner
Copy link

If tahoe backup attempts an upload and the client node it is using reports an error, the tahoe backup process crashes with an unhandled exception.

For example:

Traceback (most recent call last):
  File "/usr/lib/python2.7/threading.py", line 801, in __bootstrap_inner
    self.run()
  File "/usr/lib/python2.7/threading.py", line 754, in run
    self.__target(*self.__args, **self.__kwargs)
  File "/usr/lib/python2.7/site-packages/twisted/_threads/_threadworker.py", line 46, in work
    task()
  File "/usr/lib/python2.7/site-packages/twisted/_threads/_team.py", line 190, in doWork
    task()
--- <exception caught here> ---
  File "/usr/lib/python2.7/site-packages/twisted/python/threadpool.py", line 250, in inContext
    result = inContext.theWork()
  File "/usr/lib/python2.7/site-packages/twisted/python/threadpool.py", line 266, in <lambda>
    inContext.theWork = lambda: context.call(ctx, func, *args, **kw)
  File "/usr/lib/python2.7/site-packages/twisted/python/context.py", line 122, in callWithContext
    return self.currentContext().callWithContext(ctx, func, *args, **kw)
  File "/usr/lib/python2.7/site-packages/twisted/python/context.py", line 85, in callWithContext
    return func(*args,**kw)
  File "/usr/lib/python2.7/site-packages/allmydata/scripts/cli.py", line 543, in backup
    rc = tahoe_backup.backup(options)
  File "/usr/lib/python2.7/site-packages/allmydata/scripts/tahoe_backup.py", line 326, in backup
    return bu.run()
  File "/usr/lib/python2.7/site-packages/allmydata/scripts/tahoe_backup.py", line 118, in run
    new_backup_dircap = self.process(options.from_dir)
  File "/usr/lib/python2.7/site-packages/allmydata/scripts/tahoe_backup.py", line 189, in process
    childcap = self.process(childpath)
  File "/usr/lib/python2.7/site-packages/allmydata/scripts/tahoe_backup.py", line 195, in process
    childcap, metadata = self.upload(childpath)
  File "/usr/lib/python2.7/site-packages/allmydata/scripts/tahoe_backup.py", line 306, in upload
    raise HTTPError("Error during file PUT", resp)
allmydata.scripts.common_http.HTTPError: Error during file PUT: 500 Internal Server Error
Traceback (most recent call last):
  File "/usr/lib/python2.7/site-packages/allmydata/immutable/upload.py", line 933, in start
    d = self.start_encrypted(eu)
  File "/usr/lib/python2.7/site-packages/allmydata/immutable/upload.py", line 960, in start_encrypted
    d.addCallback(self.locate_all_shareholders, started)
  File "/usr/lib/python2.7/site-packages/twisted/internet/defer.py", line 321, in addCallback
    callbackKeywords=kw)
  File "/usr/lib/python2.7/site-packages/twisted/internet/defer.py", line 310, in addCallbacks
    self._runCallbacks()
--- <exception caught here> ---
  File "/usr/lib/python2.7/site-packages/twisted/internet/defer.py", line 653, in _runCallbacks
    current.result = callback(current.result, *args, **kw)
  File "/usr/lib/python2.7/site-packages/allmydata/immutable/upload.py", line 988, in locate_all_shareholders
    num_segments, n, k, desired)
  File "/usr/lib/python2.7/site-packages/allmydata/immutable/upload.py", line 264, in get_shareholders
    raise NoServersError("client gave us zero servers")
allmydata.interfaces.NoServersError: client gave us zero servers

The backup does not complete and the user is required to have a high level of technical expertise to understand what is happening.

Many such errors may be due to transient network conditions. In some cases, it may be worth trying again instead of crashing. In others, if the backup is going to end prematurely, this should be reported in a way more easily understood by the user.

If `tahoe backup` attempts an upload and the client node it is using reports an error, the `tahoe backup` process crashes with an unhandled exception. For example: ``` Traceback (most recent call last): File "/usr/lib/python2.7/threading.py", line 801, in __bootstrap_inner self.run() File "/usr/lib/python2.7/threading.py", line 754, in run self.__target(*self.__args, **self.__kwargs) File "/usr/lib/python2.7/site-packages/twisted/_threads/_threadworker.py", line 46, in work task() File "/usr/lib/python2.7/site-packages/twisted/_threads/_team.py", line 190, in doWork task() --- <exception caught here> --- File "/usr/lib/python2.7/site-packages/twisted/python/threadpool.py", line 250, in inContext result = inContext.theWork() File "/usr/lib/python2.7/site-packages/twisted/python/threadpool.py", line 266, in <lambda> inContext.theWork = lambda: context.call(ctx, func, *args, **kw) File "/usr/lib/python2.7/site-packages/twisted/python/context.py", line 122, in callWithContext return self.currentContext().callWithContext(ctx, func, *args, **kw) File "/usr/lib/python2.7/site-packages/twisted/python/context.py", line 85, in callWithContext return func(*args,**kw) File "/usr/lib/python2.7/site-packages/allmydata/scripts/cli.py", line 543, in backup rc = tahoe_backup.backup(options) File "/usr/lib/python2.7/site-packages/allmydata/scripts/tahoe_backup.py", line 326, in backup return bu.run() File "/usr/lib/python2.7/site-packages/allmydata/scripts/tahoe_backup.py", line 118, in run new_backup_dircap = self.process(options.from_dir) File "/usr/lib/python2.7/site-packages/allmydata/scripts/tahoe_backup.py", line 189, in process childcap = self.process(childpath) File "/usr/lib/python2.7/site-packages/allmydata/scripts/tahoe_backup.py", line 195, in process childcap, metadata = self.upload(childpath) File "/usr/lib/python2.7/site-packages/allmydata/scripts/tahoe_backup.py", line 306, in upload raise HTTPError("Error during file PUT", resp) allmydata.scripts.common_http.HTTPError: Error during file PUT: 500 Internal Server Error Traceback (most recent call last): File "/usr/lib/python2.7/site-packages/allmydata/immutable/upload.py", line 933, in start d = self.start_encrypted(eu) File "/usr/lib/python2.7/site-packages/allmydata/immutable/upload.py", line 960, in start_encrypted d.addCallback(self.locate_all_shareholders, started) File "/usr/lib/python2.7/site-packages/twisted/internet/defer.py", line 321, in addCallback callbackKeywords=kw) File "/usr/lib/python2.7/site-packages/twisted/internet/defer.py", line 310, in addCallbacks self._runCallbacks() --- <exception caught here> --- File "/usr/lib/python2.7/site-packages/twisted/internet/defer.py", line 653, in _runCallbacks current.result = callback(current.result, *args, **kw) File "/usr/lib/python2.7/site-packages/allmydata/immutable/upload.py", line 988, in locate_all_shareholders num_segments, n, k, desired) File "/usr/lib/python2.7/site-packages/allmydata/immutable/upload.py", line 264, in get_shareholders raise NoServersError("client gave us zero servers") allmydata.interfaces.NoServersError: client gave us zero servers ``` The backup does not complete and the user is required to have a high level of technical expertise to understand what is happening. Many such errors may be due to transient network conditions. In some cases, it may be worth trying again instead of crashing. In others, if the backup is going to end prematurely, this should be reported in a way more easily understood by the user.
tahoe-lafs added the
code-frontend-cli
normal
defect
1.12.1
 labels 2018-04-10 15:41:09 +00:00
tahoe-lafs added this to the undecided milestone 2018-04-10 15:41:09 +00:00
Sign in to join this conversation.
No Branch/Tag specified
Branches Tags
No results found.
No results found.
Labels
Clear labels   
0.2.0

   
0.3.0

   
0.4.0

   
0.5.0

   
0.5.1

   
0.6.0

   
0.6.1

   
0.7.0

   
0.8.0

   
0.9.0

   
1.0.0

   
1.1.0

   
1.10.0

   
1.10.1

   
1.10.2

   
1.10a2

   
1.11.0

   
1.12.0

   
1.12.1

   
1.13.0

   
1.14.0

   
1.15.0

   
1.15.1

   
1.2.0

   
1.3.0

   
1.4.1

   
1.5.0

   
1.6.0

   
1.6.1

   
1.7.0

   
1.7.1

   
1.7β

   
1.8.0

   
1.8.1

   
1.8.2

   
1.8.3

   
1.8β

   
1.9.0

   
1.9.0-s3branch

   
1.9.0a1

   
1.9.0a2

   
1.9.0b1

   
1.9.1

   
1.9.2

   
1.9.2a1

   
LeastAuthority.com automation

   
blocker

   
cannot reproduce

   
cloud-branch

   
code

catch-all for anything that can be fixed by writing code but isn't classified better

  
code-dirnodes

anything involving tahoe directories

  
code-encoding

immutable-file encoding format/layout, cap format, encoding/decoding algorithms

  
code-frontend

general frontend things: new user-facing interfaces, FTP/SFTP servers, FUSE-like interfaces

  
code-frontend-cli

CLI tools

  
code-frontend-ftp-sftp

   
code-frontend-magic-folder

   
code-frontend-web

webapi interfaces, user-facing "WUI" interfaces

  
code-mutable

anything involving mutable files: encoding/decoding, share format

  
code-network

Introducer, locating storage servers, establishing/maintaining connections to them

  
code-nodeadmin

node startup/shutdown, tools to create nodes, logging tools, management/monitoring tools, manhole, disk-space-limiting tools

  
code-peerselection

server selection/sorting algorithm, rebalancing code, allocation policy, swarming-download

  
code-storage

storage-server implementation, share-storage directory layout, client-to-server share transfer protocol

  
contrib

problems with non-core things that live in the source:contrib/ directory

  
critical

   
defect

   
dev-infrastructure

things that help us build Tahoe: buildbot, automated speed/memory/code-coverage tests and results-displayers, IRC channels, mailing lists, this Trac instance

  
documentation

docs items. Also use 'docs' keyword on tickets in more specific components.

  
duplicate

   
enhancement

   
fixed

   
invalid

   
major

   
minor

   
n/a

   
normal

   
operational

things involved in running a tahoe grid, external tools to monitor/maintain a grid (like "nodeadmin" but larger-scale). Was also used for issues with the allmydata.com grid.

  
packaging

setup.py script, library dependencies, binary packages, licensing, installation instructions

  
somebody else's problem

   
supercritical

   
task

   
trivial

   
unknown

Uncategorized. All tickets default to this component until someone updates it.

  
was already fixed

   
website

things about the tahoe-lafs.org website (and sometimes this Trac instance, shared with 'dev-infrastructure')

  
wontfix

   
worksforme
No labels
0.2.0
0.3.0
0.4.0
0.5.0
0.5.1
0.6.0
0.6.1
0.7.0
0.8.0
0.9.0
1.0.0
1.1.0
1.10.0
1.10.1
1.10.2
1.10a2
1.11.0
1.12.0
1.12.1
1.13.0
1.14.0
1.15.0
1.15.1
1.2.0
1.3.0
1.4.1
1.5.0
1.6.0
1.6.1
1.7.0
1.7.1
1.7β
1.8.0
1.8.1
1.8.2
1.8.3
1.8β
1.9.0
1.9.0-s3branch
1.9.0a1
1.9.0a2
1.9.0b1
1.9.1
1.9.2
1.9.2a1
LeastAuthority.com automation
blocker
cannot reproduce
cloud-branch
code
code-dirnodes
code-encoding
code-frontend
code-frontend-cli
code-frontend-ftp-sftp
code-frontend-magic-folder
code-frontend-web
code-mutable
code-network
code-nodeadmin
code-peerselection
code-storage
contrib
critical
defect
dev-infrastructure
documentation
duplicate
enhancement
fixed
invalid
major
minor
n/a
normal
operational
packaging
somebody else's problem
supercritical
task
trivial
unknown
was already fixed
website
wontfix
worksforme
Milestone
Clear milestone
No items
No milestone
undecided
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: tahoe-lafs/trac-2024-07-25#2918
No description provided.
Delete branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?