add tests to catch things like tox.ini not being in MANIFEST.in #2779

Open
opened 2016-04-13 07:00:01 +00:00 by warner · 5 comments
warner commented 2016-04-13 07:00:01 +00:00
Owner

I got an IRC report today that you can't run tox from an unpacked 1.11.0 source tarball, because I forgot to include tox.ini in the MANIFEST.in file (so it doesn't get copied into sdist tarballs). Oops.

The task is to make a buildbot test that (via a checked-in helper script) makes an sdist tarball, unpacks it into a new directory, then steps into that directory and runs 'tox' successfully.

It's probably ok if we don't run a full test suite, just enough to make sure the test files got copied in.

It might also be good to have a script that builds+unpacks an sdist, then compares the files in the original (git checkout) source tree against the unpacked ones, and fails if there are any unexpected differences.

I got an IRC report today that you can't run `tox` from an unpacked 1.11.0 source tarball, because I forgot to include `tox.ini` in the `MANIFEST.in` file (so it doesn't get copied into sdist tarballs). Oops. The task is to make a buildbot test that (via a checked-in helper script) makes an sdist tarball, unpacks it into a new directory, then steps into that directory and runs 'tox' successfully. It's probably ok if we don't run a full test suite, just enough to make sure the test files got copied in. It might also be good to have a script that builds+unpacks an sdist, then compares the files in the original (git checkout) source tree against the unpacked ones, and fails if there are any unexpected differences.
tahoe-lafs added the
packaging
major
defect
1.11.0
labels 2016-04-13 07:00:01 +00:00
tahoe-lafs added this to the 1.12.0 milestone 2016-04-13 07:00:01 +00:00
Brian Warner <warner@lothar.com> commented 2016-04-13 07:03:27 +00:00
Author
Owner

In 04f1a3c/trunk:

Merge branch 'pr259' from meejah:add-tox

refs ticket:2779
In [04f1a3c/trunk](/tahoe-lafs/trac-2024-07-25/commit/04f1a3c38de577a63ce24bf6737ec98d02be4a7d): ``` Merge branch 'pr259' from meejah:add-tox refs ticket:2779 ```
warner commented 2016-04-13 22:21:14 +00:00
Author
Owner
(https://warehouse.python.org/project/check-manifest/) would be useful.
tahoe-lafs changed title from add tox.ini to MANIFEST.in to add tests to catch things like tox.ini not being in MANIFEST.in 2016-04-13 22:21:14 +00:00
warner commented 2016-06-28 18:20:37 +00:00
Author
Owner

moving most tickets from 1.12 to 1.13 so we can release 1.12 with magic-folders

moving most tickets from 1.12 to 1.13 so we can release 1.12 with magic-folders
tahoe-lafs modified the milestone from 1.12.0 to 1.13.0 2016-06-28 18:20:37 +00:00
exarkun commented 2020-06-30 14:45:13 +00:00
Author
Owner

Moving open issues out of closed milestones.

Moving open issues out of closed milestones.
tahoe-lafs modified the milestone from 1.13.0 to 1.15.0 2020-06-30 14:45:13 +00:00
meejah commented 2021-03-30 18:40:19 +00:00
Author
Owner

Ticket retargeted after milestone closed

Ticket retargeted after milestone closed
tahoe-lafs modified the milestone from 1.15.0 to soon 2021-03-30 18:40:19 +00:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: tahoe-lafs/trac-2024-07-25#2779
No description provided.