tahoe-lafs/trac-2024-07-25

failure in test_web.Web.test_welcome on Windows #2725

New issue

Closed

opened 2016-02-02 19:23:54 +00:00 by daira · 7 comments

daira commented

2016-02-02 19:23:54 +00:00

Owner

FAIL
Traceback (most recent call last):
> File "c:\users\buildslave\tahoe\daira_win7-64_py2_7\build\src\allmydata\test\test_web.py", line 637, in _check
    self.failUnless(re.search(u'<div class="status-indicator"><img (src="img/connected-yes.png" |alt="Connected" ){2}/></div>\n                <a( class="timestamp"| title="1970-01-01 13:00:10"){2}>1d\u00A00h\u00A00m\u00A050s</a>', res_u), res_u)
> File "C:\Python27\lib\site-packages\twisted\trial\_synctest.py", line 400, in assertTrue
    super(_Assertions, self).assertTrue(condition, msg)
> File "C:\Python27\lib\unittest\case.py", line 422, in assertTrue
    raise self.failureException(msg)
twisted.trial.unittest.FailTest: <FailTest instance at 0x5ef5240 with str error:
 Traceback (most recent call last):
> File "C:\Python27\lib\site-packages\twisted\python\reflect.py", line 443, in safe_str
    return str(o)
[UnicodeEncodeError](wiki/UnicodeEncodeError): 'ascii' codec can't encode character u'\u263a' in position 1004: ordinal not in range(128)
>

allmydata.test.test_web.Web.test_welcome

``` FAIL Traceback (most recent call last): > File "c:\users\buildslave\tahoe\daira_win7-64_py2_7\build\src\allmydata\test\test_web.py", line 637, in _check self.failUnless(re.search(u'<div class="status-indicator"><img (src="img/connected-yes.png" |alt="Connected" ){2}/></div>\n <a( class="timestamp"| title="1970-01-01 13:00:10"){2}>1d\u00A00h\u00A00m\u00A050s</a>', res_u), res_u) > File "C:\Python27\lib\site-packages\twisted\trial\_synctest.py", line 400, in assertTrue super(_Assertions, self).assertTrue(condition, msg) > File "C:\Python27\lib\unittest\case.py", line 422, in assertTrue raise self.failureException(msg) twisted.trial.unittest.FailTest: <FailTest instance at 0x5ef5240 with str error: Traceback (most recent call last): > File "C:\Python27\lib\site-packages\twisted\python\reflect.py", line 443, in safe_str return str(o) [UnicodeEncodeError](wiki/UnicodeEncodeError): 'ascii' codec can't encode character u'\u263a' in position 1004: ordinal not in range(128) > allmydata.test.test_web.Web.test_welcome ```

tahoe-lafs added the

labels 2016-02-02 19:23:54 +00:00

daira commented

2016-02-02 19:24:29 +00:00

Author

Owner

This may be related to the recent fix for #2663.

Daira Hopwood <daira@jacaranda.org> commented

2016-02-02 19:36:28 +00:00

Author

Owner

In e1285d2/trunk:

Fix an error-reporting problem in test_welcome (this does not fix the underlying failure). refs ticket:2725

Signed-off-by: Daira Hopwood <daira@jacaranda.org>

In [e1285d2/trunk](/tahoe-lafs/trac-2024-07-25/commit/e1285d27b9b3203c1e968720177a46ae0a696983): ``` Fix an error-reporting problem in test_welcome (this does not fix the underlying failure). refs ticket:2725 Signed-off-by: Daira Hopwood <daira@jacaranda.org> ```

daira commented

2016-02-02 19:43:39 +00:00

Author

Owner

The current failure is at https://tahoe-lafs.org/buildbot-tahoe-lafs/builders/Daira%20Win7-64%20py2.7/builds/71/steps/test/logs/stdio (it is not necessarily Unicode-related, that was just a problem when trying to print res_u after the actual test condition had failed).

The current failure is at <https://tahoe-lafs.org/buildbot-tahoe-lafs/builders/Daira%20Win7-64%20py2.7/builds/71/steps/test/logs/stdio> (it is not necessarily Unicode-related, that was just a problem when trying to print `res_u` after the actual test condition had failed).

daira commented

2016-02-05 19:12:45 +00:00

Author

Owner

The underlying problem was that allmydata.test.common_util.TimezoneMixin.setTimezone doesn't work on Windows due to lack of time.tzset.

The underlying problem was that `allmydata.test.common_util.TimezoneMixin.setTimezone` doesn't work on Windows due to lack of `time.tzset`.

tahoe-lafs changed title from ~~Unicode-related failure in test_web.Web.test_welcome on Windows~~ to failure in test_web.Web.test_welcome on Windows

2016-02-05 19:12:45 +00:00

daira commented

2016-02-08 15:20:07 +00:00

Author

Owner

Please review: https://github.com/tahoe-lafs/tahoe-lafs/pull/236

Please review: <https://github.com/tahoe-lafs/tahoe-lafs/pull/236>

Daira Hopwood <daira@jacaranda.org> commented

2016-02-08 22:57:38 +00:00

Author

Owner

In c6449b6/trunk:

Fix tests on platforms without time.tzset (e.g. Windows). fixes ticket:2725

Signed-off-by: Daira Hopwood <daira@jacaranda.org>

In [c6449b6/trunk](/tahoe-lafs/trac-2024-07-25/commit/c6449b687a6b2fc95ec9f6afd938a20f60a731ab): ``` Fix tests on platforms without time.tzset (e.g. Windows). fixes ticket:2725 Signed-off-by: Daira Hopwood <daira@jacaranda.org> ```

tahoe-lafs added the

fixed

label 2016-02-08 22:57:38 +00:00

Daira Hopwood <daira@jacaranda.org> closed this issue

2016-02-08 22:57:38 +00:00

warner commented

2016-03-22 05:03:36 +00:00

Author

Owner

Milestone renamed

tahoe-lafs added this to the 1.11.0 milestone 2016-03-22 05:03:36 +00:00