tahoe-lafs/trac-2024-07-25

consider whether to use @inlineCallbacks (in tests or more generally) #2507

New issue

Open

opened 2015-09-17 08:18:26 +00:00 by daira · 1 comment

daira commented

2015-09-17 08:18:26 +00:00

Owner

meejah: we don't use inlineCallbacks in Tahoe mainly due to inertia -- the vast majority of the codebase was written without them...
I had some minor technical reservations about them (and about mixing the two styles) but I should probably reconsider whether those are really justified
currently our only use of them is in the tests for some of the cloud backend service providers (on a dev branch) that Leif wrote
I think there's no objection to using them more generally in tests

For this ticket, understand pros and cons of using @inlineCallbacks and add a section to the CodingStandards with guidelines for their use. (This might be very short if no guidelines are needed!)

<daira> meejah: we don't use inlineCallbacks in Tahoe mainly due to inertia -- the vast majority of the codebase was written without them... <daira> I had some minor technical reservations about them (and about mixing the two styles) but I should probably reconsider whether those are really justified <daira> currently our only use of them is in the tests for some of the cloud backend service providers (on a dev branch) that Leif wrote <daira> I think there's no objection to using them more generally in tests For this ticket, understand pros and cons of using @inlineCallbacks and add a section to the [CodingStandards](wiki/CodingStandards) with guidelines for their use. (This might be very short if no guidelines are needed!)

tahoe-lafs added the

labels 2015-09-17 08:18:26 +00:00

tahoe-lafs added this to the undecided milestone 2015-09-17 08:18:26 +00:00

tahoe-lafs added

and removed

labels 2015-09-17 08:21:45 +00:00

warner commented

2016-09-28 08:10:03 +00:00

Author

Owner

The answer is yes, we should use inlineCallbacks. All the new tests I'm writing these days use it. mock too.

The answer is yes, we should use inlineCallbacks. All the new tests I'm writing these days use it. `mock` too.

Sign in to join this conversation.

No labels

LeastAuthority.com automation

cannot reproduce

code-frontend-cli

code-frontend-ftp-sftp

code-frontend-magic-folder

code-frontend-web

code-peerselection

dev-infrastructure

somebody else's problem

was already fixed

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: tahoe-lafs/trac-2024-07-25#2507

No description provided.