include git hash in the full version info #2347

Closed
opened 2014-12-03 22:18:08 +00:00 by zooko · 2 comments
zooko commented 2014-12-03 22:18:08 +00:00
Owner

When people report interesting bugs like this one: comment:132789, I'd really like to be able to tell what version of the software they were running. Version numbers do not achieve this goal — witness the fact that the software they are running reports its versions as "allmydata-tahoe: 1.9.2", in the flogtool incident report file:

Application Versions:
Nevow: 0.10.0
Twisted: 12.0.0
allmydata-tahoe: 1.9.2
foolscap: 0.6.4
mock: 0.8.0
platform: Linux-debian_7.0-x86_64-64bit_ELF
pyOpenSSL: 0.13
pyasn1: unknown
pycrypto: 2.6
pycryptopp: 0.6.0.1206569328141510525648634803928199668821045408958
python: 2.7.3
setuptools: 0.6
simplejson: 2.5.2
sqlite3: 2.6.0
twisted: 12.0.0
zfec: 1.4.24
zope.interface: unknown

But there are actually patches applied to it as part of the I2P fork.
The solution to this is to include into the version info the current git hash, and the current git dirty-state, when the software is built.

When people report interesting bugs like this one: [comment:132789](/tahoe-lafs/trac-2024-07-25/issues/1939#issuecomment-132789), I'd really like to be able to tell what version of the software they were running. Version numbers do not achieve this goal — witness the fact that the software they are running reports its versions as "allmydata-tahoe: 1.9.2", in the flogtool incident report file: ``` Application Versions: Nevow: 0.10.0 Twisted: 12.0.0 allmydata-tahoe: 1.9.2 foolscap: 0.6.4 mock: 0.8.0 platform: Linux-debian_7.0-x86_64-64bit_ELF pyOpenSSL: 0.13 pyasn1: unknown pycrypto: 2.6 pycryptopp: 0.6.0.1206569328141510525648634803928199668821045408958 python: 2.7.3 setuptools: 0.6 simplejson: 2.5.2 sqlite3: 2.6.0 twisted: 12.0.0 zfec: 1.4.24 zope.interface: unknown ``` But there are actually patches applied to it as part of the I2P fork. The solution to this is to include into the version info the current git hash, and the current git dirty-state, when the software is built.
tahoe-lafs added the
packaging
normal
defect
1.10.0
labels 2014-12-03 22:18:08 +00:00
tahoe-lafs added this to the undecided milestone 2014-12-03 22:18:08 +00:00
daira commented 2014-12-03 22:26:23 +00:00
Author
Owner

Are you sure this is not already fixed?

Are you sure this is not already fixed?
daira commented 2014-12-03 22:54:09 +00:00
Author
Owner

Already fixed in #1953 I think. Please reopen if #1953 did not do what you want.

Already fixed in #1953 I think. Please reopen if #1953 did not do what you want.
tahoe-lafs added the
was already fixed
label 2014-12-03 22:54:09 +00:00
tahoe-lafs modified the milestone from undecided to 1.11.0 2014-12-03 22:54:09 +00:00
daira closed this issue 2014-12-03 22:54:09 +00:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: tahoe-lafs/trac-2024-07-25#2347
No description provided.