tahoe-lafs/trac-2024-07-25

maybe stop using tac files to indicate node type? #2325

New issue

Open

opened 2014-10-27 01:32:52 +00:00 by daira · 1 comment

daira commented

2014-10-27 01:32:52 +00:00

Owner

In /tahoe-lafs/trac-2024-07-25/issues/8664#comment:50, warner wrote:

Note that this patch [...] stops using the contents of the .tac files, but still relies upon their presence, in particular their filename: if "client" is a substring of the filename of the first .tac file found in the node's basedir, then we instantiate a Client, if "introducer" is in the string, we instantiate an IntroducerNode, etc.

We'll want another patch, after 1.11, to move this indicator into tahoe.cfg (and look for a .tac filename as a backwards-compatibility tool).

I'm not sure that we do want this; a simpler approach would be to keep the .tac file marker, possibly just as a zero-length file. That would keep nodes created by future versions runnable by 1.11 (although not by earlier versions). Still, I've created this ticket to discuss it, and to allow us to close #1159.

In [/tahoe-lafs/trac-2024-07-25/issues/8664](/tahoe-lafs/trac-2024-07-25/issues/8664)#comment:50, warner wrote: > Note that this patch [...] stops using the *contents* of the .tac files, but still relies upon their presence, in particular their filename: if "client" is a substring of the filename of the first .tac file found in the node's basedir, then we instantiate a Client, if "introducer" is in the string, we instantiate an IntroducerNode, etc. > > We'll want another patch, after 1.11, to move this indicator into `tahoe.cfg` (and look for a `.tac` filename as a backwards-compatibility tool). I'm not sure that we do want this; a simpler approach would be to keep the `.tac` file marker, possibly just as a zero-length file. That would keep nodes created by future versions runnable by 1.11 (although not by earlier versions). Still, I've created this ticket to discuss it, and to allow us to close #1159.

tahoe-lafs added the

labels 2014-10-27 01:32:52 +00:00

tahoe-lafs added this to the undecided milestone 2014-10-27 01:32:52 +00:00

warner commented

2016-09-10 06:56:21 +00:00

Author

Owner

I'd like to get rid of these files, because when I want to edit tahoe.cfg, I type "ta TAB", but my editor/shell won't fully complete for me, because tahoe-client.tac shares a prefix. A minor reason, I'll admit :).

The question is what signal should indicate the node type? I think the main question is client/server vs introducer, and the presence of a client section in tahoe.cfg is a good indicator (perhaps look for either client or storage, to accomodate future server-only no-client nodes, which would have storage but not client).

I'd like to get rid of these files, because when I want to edit `tahoe.cfg`, I type "ta TAB", but my editor/shell won't fully complete for me, because `tahoe-client.tac` shares a prefix. A minor reason, I'll admit :). The question is what signal should indicate the node type? I think the main question is client/server vs introducer, and the presence of a `client` section in `tahoe.cfg` is a good indicator (perhaps look for either `client` or `storage`, to accomodate future server-only no-client nodes, which would have `storage` but not `client`).

tahoe-lafs modified the milestone from undecided to eventually

2016-09-10 06:56:21 +00:00