tahoe-lafs/trac-2024-07-25
2
0
Issues 1.1k Wiki Activity

tahoe cp verbose counts from 0 to n-1 of n #1805

New issue
Closed
opened 2012-09-14 12:18:29 +00:00 by ChosenOne · 7 comments
ChosenOne commented 2012-09-14 12:18:29 +00:00
Owner
Copy link

When I use "tahoe cp" to copy files, it gives messages like

 examining 0 of 2
 examining 1 of 2

It's a simple off by one.

patch attached.

When I use "tahoe cp" to copy files, it gives messages like ``` examining 0 of 2 examining 1 of 2 ``` It's a simple off by one. patch attached.
tahoe-lafs added the
code-frontend-cli
minor
defect
1.9.2
 labels 2012-09-14 12:18:29 +00:00
tahoe-lafs added this to the undecided milestone 2012-09-14 12:18:29 +00:00
ChosenOne commented 2012-09-14 12:20:50 +00:00
Author
Owner
Copy link

Attachment tahoe_cp.py.patch (1863 bytes) added

suggested patch

**Attachment** tahoe_cp.py.patch (1863 bytes) added suggested patch
tahoe_cp.py.patch
1.8 KiB
zooko commented 2012-09-14 16:41:56 +00:00
Author
Owner
Copy link

Thank you for the patch, ChosenOne! This needs a unit test. Here are the extant [tests]source:src/allmydata/test/test_cli.py@20120904224538-66853-76911c7a332d6d1a5d5be880a192e4e9d05c155f#L1891 of the tahoe cp command. Someone (possibly you, ChosenOne) needs to make a method of class Cp which copies more than one file, and fails unless the stdout has the right count in it. Note that the do_cli helper function that is already defined in test_cli.py captures stdout by default and passes it as the second argument to the callback.

Thank you for the patch, ChosenOne! This needs a unit test. Here are the extant [tests]source:src/allmydata/test/test_cli.py@20120904224538-66853-76911c7a332d6d1a5d5be880a192e4e9d05c155f#L1891 of the `tahoe cp` command. Someone (possibly you, ChosenOne) needs to make a method of `class Cp` which copies more than one file, and fails unless the stdout has the right count in it. Note that the `do_cli` helper function that is already defined in `test_cli.py` captures stdout by default and passes it as the second argument to the callback.
ChosenOne commented 2012-09-14 17:47:14 +00:00
Author
Owner
Copy link

Attachment test_cli.patch (848 bytes) added

patch file for test

**Attachment** test_cli.patch (848 bytes) added patch file for test
test_cli.patch
848 B
ChosenOne commented 2012-09-14 17:49:02 +00:00
Author
Owner
Copy link

sorry for the confusion: I did not find the button to remove a patch, so now I uploaded a second patch file for test_cli.py. [removed --davidsarah]Now

the most recent one (test_cli.patch) works and yields a success when running
make quicktest TEST=allmydata.test.test_cli.Cp.test_copy_using_filecap :)

sorry for the confusion: I did not find the button to remove a patch, so now I uploaded a second patch file for test_cli.py. [removed --davidsarah]Now the most recent one (test_cli.patch) works and yields a success when running `make quicktest TEST=allmydata.test.test_cli.Cp.test_copy_using_filecap` :)
tahoe-lafs added
normal
 and removed
minor
 labels 2012-09-14 21:07:57 +00:00
tahoe-lafs modified the milestone from undecided to 1.10.0 2012-09-14 21:07:57 +00:00
davidsarah commented 2012-09-14 21:11:46 +00:00
Author
Owner
Copy link

The test patch adds extraneous whitespace on a blank line.

Other than that +1, good to apply.

The test patch adds extraneous whitespace on a blank line. Other than that +1, good to apply.
ChosenOne commented 2012-09-15 14:00:50 +00:00
Author
Owner
Copy link

Thanks for the review.

Thanks for the review.
davidsarah commented 2012-11-22 01:32:40 +00:00
Author
Owner
Copy link

Fixed in changeset:595d611c9b4b29c8.

Fixed in changeset:595d611c9b4b29c8.
tahoe-lafs added the
fixed
 label 2012-11-22 01:32:52 +00:00
davidsarah closed this issue 2012-11-22 01:32:52 +00:00
Sign in to join this conversation.
No Branch/Tag specified
Branches Tags
No results found.
No results found.
Labels
Clear labels   
0.2.0

   
0.3.0

   
0.4.0

   
0.5.0

   
0.5.1

   
0.6.0

   
0.6.1

   
0.7.0

   
0.8.0

   
0.9.0

   
1.0.0

   
1.1.0

   
1.10.0

   
1.10.1

   
1.10.2

   
1.10a2

   
1.11.0

   
1.12.0

   
1.12.1

   
1.13.0

   
1.14.0

   
1.15.0

   
1.15.1

   
1.2.0

   
1.3.0

   
1.4.1

   
1.5.0

   
1.6.0

   
1.6.1

   
1.7.0

   
1.7.1

   
1.7β

   
1.8.0

   
1.8.1

   
1.8.2

   
1.8.3

   
1.8β

   
1.9.0

   
1.9.0-s3branch

   
1.9.0a1

   
1.9.0a2

   
1.9.0b1

   
1.9.1

   
1.9.2

   
1.9.2a1

   
LeastAuthority.com automation

   
blocker

   
cannot reproduce

   
cloud-branch

   
code

catch-all for anything that can be fixed by writing code but isn't classified better

  
code-dirnodes

anything involving tahoe directories

  
code-encoding

immutable-file encoding format/layout, cap format, encoding/decoding algorithms

  
code-frontend

general frontend things: new user-facing interfaces, FTP/SFTP servers, FUSE-like interfaces

  
code-frontend-cli

CLI tools

  
code-frontend-ftp-sftp

   
code-frontend-magic-folder

   
code-frontend-web

webapi interfaces, user-facing "WUI" interfaces

  
code-mutable

anything involving mutable files: encoding/decoding, share format

  
code-network

Introducer, locating storage servers, establishing/maintaining connections to them

  
code-nodeadmin

node startup/shutdown, tools to create nodes, logging tools, management/monitoring tools, manhole, disk-space-limiting tools

  
code-peerselection

server selection/sorting algorithm, rebalancing code, allocation policy, swarming-download

  
code-storage

storage-server implementation, share-storage directory layout, client-to-server share transfer protocol

  
contrib

problems with non-core things that live in the source:contrib/ directory

  
critical

   
defect

   
dev-infrastructure

things that help us build Tahoe: buildbot, automated speed/memory/code-coverage tests and results-displayers, IRC channels, mailing lists, this Trac instance

  
documentation

docs items. Also use 'docs' keyword on tickets in more specific components.

  
duplicate

   
enhancement

   
fixed

   
invalid

   
major

   
minor

   
n/a

   
normal

   
operational

things involved in running a tahoe grid, external tools to monitor/maintain a grid (like "nodeadmin" but larger-scale). Was also used for issues with the allmydata.com grid.

  
packaging

setup.py script, library dependencies, binary packages, licensing, installation instructions

  
somebody else's problem

   
supercritical

   
task

   
trivial

   
unknown

Uncategorized. All tickets default to this component until someone updates it.

  
was already fixed

   
website

things about the tahoe-lafs.org website (and sometimes this Trac instance, shared with 'dev-infrastructure')

  
wontfix

   
worksforme
No labels
0.2.0
0.3.0
0.4.0
0.5.0
0.5.1
0.6.0
0.6.1
0.7.0
0.8.0
0.9.0
1.0.0
1.1.0
1.10.0
1.10.1
1.10.2
1.10a2
1.11.0
1.12.0
1.12.1
1.13.0
1.14.0
1.15.0
1.15.1
1.2.0
1.3.0
1.4.1
1.5.0
1.6.0
1.6.1
1.7.0
1.7.1
1.7β
1.8.0
1.8.1
1.8.2
1.8.3
1.8β
1.9.0
1.9.0-s3branch
1.9.0a1
1.9.0a2
1.9.0b1
1.9.1
1.9.2
1.9.2a1
LeastAuthority.com automation
blocker
cannot reproduce
cloud-branch
code
code-dirnodes
code-encoding
code-frontend
code-frontend-cli
code-frontend-ftp-sftp
code-frontend-magic-folder
code-frontend-web
code-mutable
code-network
code-nodeadmin
code-peerselection
code-storage
contrib
critical
defect
dev-infrastructure
documentation
duplicate
enhancement
fixed
invalid
major
minor
n/a
normal
operational
packaging
somebody else's problem
supercritical
task
trivial
unknown
was already fixed
website
wontfix
worksforme
Milestone
Clear milestone
No items
No milestone
1.10.0
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: tahoe-lafs/trac-2024-07-25#1805
No description provided.
Delete branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?