tahoe-lafs/trac-2024-07-25

make test-clean gives false alarms #180

New issue

Closed

opened 2007-10-15 18:32:10 +00:00 by zooko · 2 comments

zooko commented

2007-10-15 18:32:10 +00:00

Owner

This seems like a trivial problem to fix, but I can't figure out which trivial fix is the right one, so I'm opening this ticket. The problem is that make test-clean turns the buildbot red if new Python files have been added, e.g. http://allmydata.org/buildbot/builders/clean/builds/414

One trivial fix would be to make && make clean before beginning the test, but that would allow uncleaned messes to pass the test. Another would be to exclude *.pyc files from consideration, which raises the question of whether we should exclude all of the .darcs-boringfile regexes from consideration, which raises the question of whether we shouldn't make test-clean be a Python script like test-darcs-boringfile is instead of a GNUmake script, which raises issue #179. ;-)

This seems like a trivial problem to fix, but I can't figure out which trivial fix is the right one, so I'm opening this ticket. The problem is that `make test-clean` turns the buildbot red if new Python files have been added, e.g. <http://allmydata.org/buildbot/builders/clean/builds/414> One trivial fix would be to `make && make clean` before beginning the test, but that would allow uncleaned messes to pass the test. Another would be to exclude *.pyc files from consideration, which raises the question of whether we should exclude all of the .darcs-boringfile regexes from consideration, which raises the question of whether we shouldn't make `test-clean` be a Python script like `test-darcs-boringfile` is instead of a GNUmake script, which raises issue #179. ;-)

tahoe-lafs added the

labels 2007-10-15 18:32:10 +00:00

tahoe-lafs added this to the 0.7.0 milestone 2007-10-15 18:32:10 +00:00

zooko commented

2007-10-15 20:50:25 +00:00

Author

Owner

Brian helped me realize that the reason this cruft is appearing is that the new find_trial.py script gets executed whenever the Makefile gets evaluated. After he gets back from lunch he'll probably refactor it to execute find_trial.py only in a make command and thus fix this ticket...

Brian helped me realize that the reason this cruft is appearing is that the new find_trial.py script gets executed whenever the Makefile gets evaluated. After he gets back from lunch he'll probably refactor it to execute find_trial.py only in a make command and thus fix this ticket...

warner commented

2007-10-15 22:07:58 +00:00

Author

Owner

done, in changeset:1e04ad47208d71a6.

done, in changeset:1e04ad47208d71a6.

tahoe-lafs added the

label 2007-10-15 22:08:26 +00:00

tahoe-lafs modified the milestone from 0.7.0 to 0.6.1

2007-10-15 22:08:26 +00:00

warner closed this issue

2007-10-15 22:08:26 +00:00

Sign in to join this conversation.

No labels

LeastAuthority.com automation

cannot reproduce

code-frontend-cli

code-frontend-ftp-sftp

code-frontend-magic-folder

code-frontend-web

code-peerselection

dev-infrastructure

somebody else's problem

was already fixed

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: tahoe-lafs/trac-2024-07-25#180

No description provided.