tahoe-lafs/trac-2024-07-25

type error in ServerMap.copy? #1785

New issue

Closed

opened 2012-07-02 19:19:36 +00:00 by davidsarah · 3 comments

davidsarah commented

2012-07-02 19:19:36 +00:00

Owner

[ServerMap]source:src/allmydata/mutable/servermap.py@5478#L122 has an update_data attribute that is not set on the copy returned by ServerMap.copy. I don't know whether this case is ever exercised.

[ServerMap]source:src/allmydata/mutable/servermap.py@5478#L122 has an `update_data` attribute that is not set on the copy returned by `ServerMap.copy`. I don't know whether this case is ever exercised.

tahoe-lafs added the

labels 2012-07-02 19:19:36 +00:00

tahoe-lafs added this to the 1.10.0 milestone 2012-07-02 19:19:36 +00:00

warner commented

2013-04-04 16:37:21 +00:00

Author

Owner

Our plan is to add:

        s.update_data = copy.deepcopy(self.update_data)

to line 136 in mutable/servermap.py.

It's probably unused, and the update_data contains only inert data (e.g. no IServer references), so it should be safe, and should protect us from future confusion.

Our plan is to add: ``` s.update_data = copy.deepcopy(self.update_data) ``` to line 136 in `mutable/servermap.py`. It's probably unused, and the `update_data` contains only inert data (e.g. no `IServer` references), so it should be safe, and should protect us from future confusion.

Brian Warner <warner@lothar.com> commented

2013-04-09 11:27:32 +00:00

Author

Owner

In changeset:4751a468408d8cc8:

ServerMap.copy(): deepcopy .update_data too. Closes #1785.

This was apparently unused, but good to copy for completeness. Tests
pass with and without the change.

In changeset:4751a468408d8cc8: ``` ServerMap.copy(): deepcopy .update_data too. Closes #1785. This was apparently unused, but good to copy for completeness. Tests pass with and without the change. ```

tahoe-lafs added the

label 2013-04-09 11:27:32 +00:00

Brian Warner <warner@lothar.com> closed this issue

2013-04-09 11:27:32 +00:00

daira commented

2013-04-10 01:58:54 +00:00

Author

Owner

Reviewed, +1.

Reviewed, +1.

Sign in to join this conversation.

No labels

LeastAuthority.com automation

cannot reproduce

code-frontend-cli

code-frontend-ftp-sftp

code-frontend-magic-folder

code-frontend-web

code-peerselection

dev-infrastructure

somebody else's problem

was already fixed

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: tahoe-lafs/trac-2024-07-25#1785

No description provided.