tahoe-lafs/trac-2024-07-25

extra newline in .furl file breaks furls, and the resulting diagnostics are not user friendl #159

New issue

Closed

opened 2007-09-29 16:34:59 +00:00 by zooko · 4 comments

zooko commented

2007-09-29 16:34:59 +00:00

Owner

Sebastian and I accidentally left an extra newline at the end of our introducer.furl file, so somewhere deep in the node there was an AttributeError involving None.

Perhaps the node should be tolerant by stripping the contents of .furl files. Certainly it should check those contents for correct formatting early and report to the user explicitly about it.

Sebastian and I accidentally left an extra newline at the end of our introducer.furl file, so somewhere deep in the node there was an [AttributeError](wiki/AttributeError) involving None. Perhaps the node should be tolerant by stripping the contents of .furl files. Certainly it should check those contents for correct formatting early and report to the user explicitly about it.

tahoe-lafs added the

labels 2007-09-29 16:34:59 +00:00

tahoe-lafs added this to the 0.6.1 milestone 2007-09-29 16:34:59 +00:00

zooko commented

2007-10-02 21:32:14 +00:00

Author

Owner

Tried to reproduce this, and it works fine with an extra newline.

So I think the real problem was that I used notepad.exe (on Windows), and it left dos-style newlines ("\r\n") instead of unix-style. Just a guess. I'll try to reproduce that next.

Tried to reproduce this, and it works fine with an extra newline. So I think the real problem was that I used notepad.exe (on Windows), and it left dos-style newlines ("\r\n") instead of unix-style. Just a guess. I'll try to reproduce that next.

warner commented

2007-10-11 08:47:59 +00:00

Author

Owner

strip() ought to remove both \r and \n, right?

strip() ought to remove both \r and \n, right?

zooko commented

2007-10-13 20:15:33 +00:00

Author

Owner

I'm closing this as unreproducible.

I'm closing this as unreproducible.

tahoe-lafs added the

label 2007-10-13 20:15:33 +00:00

zooko closed this issue

2007-10-13 20:15:33 +00:00

zooko commented

2007-10-15 20:58:16 +00:00

Author

Owner

For the record, I suspect that what really happened was that notepad.exe appended ".txt" to the file when it saved it, leaving "introducer.furl" empty.

For the record, I suspect that what really happened was that notepad.exe appended ".txt" to the file when it saved it, leaving "introducer.furl" empty.

Sign in to join this conversation.

No labels

LeastAuthority.com automation

cannot reproduce

code-frontend-cli

code-frontend-ftp-sftp

code-frontend-magic-folder

code-frontend-web

code-peerselection

dev-infrastructure

somebody else's problem

was already fixed

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: tahoe-lafs/trac-2024-07-25#159

No description provided.