tiddly_on_tahoe Tahoe patches change tiddlywiki behavior in unexpected way #1327

Open
opened 2011-01-16 01:54:45 +00:00 by arch_o_median · 4 comments
arch_o_median commented 2011-01-16 01:54:45 +00:00
Owner

Editing the "StyleSheet" shadow tiddler should override CSS settings found in the "StyleSheetColors", "StyleSheetLayout", "StyleSheetLocale", or "StyleSheetPrint" shadow tiddlers.

I compared the fresh tiddlywiki to the patched one in the following way, in each I copied and pasted the mainMenu CSS rule from "StyleSheetLayout" into "StyleSheet" and changed "text-align:right" to "text-align:left" as shown here:

#mainMenu {position:absolute; left:0; width:10em; text-align:left; line-height:1.6em; padding:1.5em 0.5em 0.5em 0.5em; font-size:1.1em;}

In the unpatched tiddlywiki (empty.html) the text shifted as expected, in the patched tiddlywiki it did not.

> Editing the "StyleSheet" shadow tiddler should override CSS settings found in the "StyleSheetColors", "StyleSheetLayout", "StyleSheetLocale", or "StyleSheetPrint" shadow tiddlers. > I compared the fresh tiddlywiki to the patched one in the following way, in each I copied and pasted the mainMenu CSS rule from "StyleSheetLayout" into "StyleSheet" and changed "text-align:right" to "text-align:left" as shown here: ``` #mainMenu {position:absolute; left:0; width:10em; text-align:left; line-height:1.6em; padding:1.5em 0.5em 0.5em 0.5em; font-size:1.1em;} ``` > In the unpatched tiddlywiki (empty.html) the text shifted as expected, in the patched tiddlywiki it did not.
tahoe-lafs added the
unknown
major
defect
1.8.1
labels 2011-01-16 01:54:45 +00:00
tahoe-lafs added this to the undecided milestone 2011-01-16 01:54:45 +00:00
arch_o_median commented 2011-01-16 01:56:32 +00:00
Author
Owner

Attachment empty.html (290568 bytes) added

native tiddlywiki

**Attachment** empty.html (290568 bytes) added native tiddlywiki
284 KiB
arch_o_median commented 2011-01-16 01:58:23 +00:00
Author
Owner

Attachment zookosmod.htm (311806 bytes) added

tiddlywiki with tahoe specific patches

**Attachment** zookosmod.htm (311806 bytes) added tiddlywiki with tahoe specific patches
arch_o_median commented 2011-01-16 01:59:01 +00:00
Author
Owner

Attachment diff_of_native_vs_patched.txt (22222 bytes) added

diff of the two tiddlywikis

**Attachment** diff_of_native_vs_patched.txt (22222 bytes) added diff of the two tiddlywikis
arch_o_median commented 2011-01-31 22:27:31 +00:00
Author
Owner

I've isolated the behavior modifying code to this chunk.

<div title="WritableTheme" modifier="Zooko" created="200812152209" modified="200812152255" tags="systemTheme" changecount="12">
<pre>|StyleSheet|##AuthorStyles|
|StyleSheetReadOnly|##ReaderStyles|

!AuthorStyles
/*```*/
[[StyleSheet]]
body {
	background: #eee;
}
/*```*/

!ReaderStyles
/*```*/
[[StyleSheet]]
body {
}
/*```*/</pre>
</div>
I've isolated the behavior modifying code to this chunk. ``` <div title="WritableTheme" modifier="Zooko" created="200812152209" modified="200812152255" tags="systemTheme" changecount="12"> <pre>|StyleSheet|##AuthorStyles| |StyleSheetReadOnly|##ReaderStyles| !AuthorStyles /*```*/ [[StyleSheet]] body { background: #eee; } /*```*/ !ReaderStyles /*```*/ [[StyleSheet]] body { } /*```*/</pre> </div> ```
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: tahoe-lafs/trac-2024-07-25#1327
No description provided.