webapi should avoid using plaintext temporary file for uploads #1176

Open
opened 2010-08-14 20:57:22 +00:00 by davidsarah · 2 comments
davidsarah commented 2010-08-14 20:57:22 +00:00
Owner

In /tahoe-lafs/trac-2024-07-25/issues/8495#comment:17, davidsarah wrote:

warner wrote:

The upload-side webapi server will still put large (>100kB) plaintext files on disk (in an anonymous tempfile),

Perhaps it should be using [EncryptedTemporaryFile]source:src/allmydata/util/fileutil.py@4609#L118?

On closer examination I think the relevant code is in twisted.web.http, so that might be easier said than done.

In [/tahoe-lafs/trac-2024-07-25/issues/8495](/tahoe-lafs/trac-2024-07-25/issues/8495)#comment:17, davidsarah wrote: > warner wrote: > > The upload-side webapi server will still put large (>100kB) plaintext files on disk (in an anonymous tempfile), > > Perhaps it should be using [EncryptedTemporaryFile]source:src/allmydata/util/fileutil.py@4609#L118? On closer examination I think the relevant code is in twisted.web.http, so that might be easier said than done.
tahoe-lafs added the
code-frontend-web
major
defect
1.8β
labels 2010-08-14 20:57:22 +00:00
tahoe-lafs added this to the 1.9.0 milestone 2010-08-14 20:57:22 +00:00
warner commented 2010-08-16 00:39:18 +00:00
Author
Owner

Hm, I like the idea. Yeah, the code is in twisted.web.http.Request.gotLength, but since we've making a subclass anyways (allmydata.webish.MyRequest), it might be pretty straightforward (add a gotLength method). OTOH, Nevow might do something weird. Should be a pretty easy experiment, though.

Hm, I like the idea. Yeah, the code is in twisted.web.http.Request.gotLength, but since we've making a subclass anyways (`allmydata.webish.MyRequest`), it might be pretty straightforward (add a `gotLength` method). OTOH, Nevow might do something weird. Should be a pretty easy experiment, though.
tahoe-lafs modified the milestone from 1.9.0 to soon 2011-08-13 23:32:30 +00:00
davidsarah commented 2011-09-26 20:28:14 +00:00
Author
Owner

#1228 is about streaming upload, which is another way to avoid having a plaintext temporary file than encrypting it.

#1228 is about streaming upload, which is another way to avoid having a plaintext temporary file than encrypting it.
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: tahoe-lafs/trac-2024-07-25#1176
No description provided.